Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct handling of --host/--port client options used with --ssl ECFLOW-1985 #134

Merged
merged 3 commits into from
Nov 19, 2024

Conversation

marcosbento
Copy link
Collaborator

No description provided.

@marcosbento marcosbento force-pushed the fix/openssl_options branch 2 times, most recently from e478b5f to 537fcca Compare November 18, 2024 15:33
@marcosbento marcosbento changed the title Correct handling of --host/--port client options when used with --ssl Correct handling of --host/--port client options used with --ssl ECFLOW-1985 Nov 18, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 98.43260% with 5 lines in your changes missing coverage. Please review.

Please upload report for BASE (hotfix/5.13.6@d91bdaf). Learn more about missing BASE report.

Files with missing lines Patch % Lines
libs/server/src/ecflow/server/ServerOptions.cpp 57.14% 3 Missing ⚠️
libs/client/src/ecflow/client/ClientInvoker.cpp 80.00% 1 Missing ⚠️
libs/server/test/TestServerConfigurations.cpp 98.75% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##             hotfix/5.13.6     #134   +/-   ##
================================================
  Coverage                 ?   48.65%           
================================================
  Files                    ?     1182           
  Lines                    ?    97875           
  Branches                 ?    14765           
================================================
  Hits                     ?    47625           
  Misses                   ?    50250           
  Partials                 ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@marcosbento marcosbento marked this pull request as ready for review November 19, 2024 07:02
@marcosbento marcosbento merged commit 2ab568b into hotfix/5.13.6 Nov 19, 2024
101 checks passed
@marcosbento marcosbento deleted the fix/openssl_options branch November 19, 2024 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants