-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix vue3 #112
base: vue3
Are you sure you want to change the base?
Fix vue3 #112
Conversation
kchobantonov
commented
May 29, 2024
- Fixing all discovered vue3/vuetify3 issues
- Integrate with Vite
- Update example project
- having more settings to control locale
- selectable icon set (material icons vs font awesome ),
- configurable blueprints (Material Design 1, 2, 3)
- configurable variants (regular, solo, filled, etc.)
- jsonform & vuetify icons are now colored based on the theme
- Integrate the date/time/datetime controls with mask - respecting the selected locale for language and formatting
…expand app settings
…emove ref="input" from number renderers
❌ Deploy Preview for jsonforms-vuetify-renderers failed.
|
@sdirix please review - at the moment we have conflicts since my work is based on the repository from 2 days ago and I have very large change as you can see - probably it will be good if we override that or something. You can review and build https://github.com/kchobantonov/jsonforms-vuetify-renderers/tree/fix-vue3 - let me know how you want this handled - didn't expect some changes and I have a lot of those at the moment. |
Hi @kchobantonov, wow, thank you for the massive contribution ❤️ While we did touch a lot of files, I think the conflicts should be rather easy to solve as conceptually it was just a small amount of changes. However I would prefer to not fully polish this PR but going in a different direction: In the JSON Forms team we decided that we want to archive this repository and move the Would you like to contribute this move to the core repository? If yes, feel free to open a PR against the main repository with the current state of the Vue3 vuetify renderers, including your additional improvements on top. If not, then we will do the move at some point in June ourselves and you can then open a PR against the core repository with the changes contained in here. |
@sdirix should will create a new PR against the main repo. |