Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

services/runner: make ping err a lot less scary #11

Merged
merged 3 commits into from
Nov 7, 2023
Merged

services/runner: make ping err a lot less scary #11

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c3b9774
services/runner: make ping err a lot less scary
NathanX-S Nov 7, 2023
a962bd8
Update RunnerService.cs
NathanX-S Nov 7, 2023
2af4a8b
Update RunnerService.cs
NathanX-S Nov 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions Services/RunnerService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,13 +30,15 @@ protected override async Task ExecuteAsync(CancellationToken stoppingToken)

if(!status)
{
throw new Exception("Server is down");
throw new Exception("Server is down.");
}
}
catch(Exception e)
// A simplified, more dev-friendly error if we hit a rather standard error.
catch(HttpRequestException httpException)
{
await _discordService.SetPresence(ActivityType.Watching, "server status: DOWN !");
Log.Error(e, "RunnerService");
// A warning is more accurate to something that may cause issues if not resolved.
Log.Warning($"RunnerService: Caught HttpRequestException from serverApi.GetPing: {httpException.Message}", "RunnerService");
}
await Task.Delay(TimeSpan.FromMinutes(1), stoppingToken);
}
Expand Down
Loading