Allow Xtext editor subclasses to control highlighting #3250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 6 460 files ± 0 6 460 suites ±0 3h 12m 7s ⏱️ +5s For more details on these failures, see this check. Results for commit 830c292. ± Comparison against base commit 4eebe72. ♻️ This comment has been updated with latest results. |
szarnekow
reviewed
Nov 25, 2024
| @@ -593,12 +593,12 @@ public void selectionChanged(final SelectionChangedEvent event) { | |||
| } | |||
| } | |||
|
|
|||
| private void installHighlightingHelper() { | |||
| protected void installHighlightingHelper() { | |||
There was a problem hiding this comment.
Please add @since 2.38 tags to the newly exposed methods
mx990
force-pushed
the
editorSubclassHighlighting
branch
from
595cd6f
to
462269d
Compare
|
can you please rebase |
Signed-off-by: Martin Jobst <martin.jobst@posteo.de>
mx990
force-pushed
the
editorSubclassHighlighting
branch
from
462269d
to
830c292
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow Xtext editor subclasses to control highlighting, for example, to (temporarily) disable semantic highlighting in order to handle very large sources. This avoids having to resort to reflection to access these methods.
Closes #3249