panic: send on closed channel #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
bkneis
pushed a commit
to bkneis/paho.golang
that referenced
this pull request
Aug 9, 2022
panic: send on closed channel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed the panic while I had the manual acknowledgments branch running in our production systems.
I'm proposing the bugfix here so that I can rebase my other branch and remove the bugfix from there, since it's not related to the manual acknowledgments.
As usual I wrote the test first to make sure that I was able to replicate the
panic. The test replicated thepanicsuccessfully at least once every three executions. Then I made the changes and ran the test in a loop for at least ~1k times. Thepanicdoes not occur anymore nor I was able to find deadlocks.These changes are now live in production along with the manual acks changes. So far we haven't noticed anything unusual.