Always keep session member view up-to-date #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spoenemann
reviewed
Jul 13, 2024
|
Weirdly enough it worked fine yesterday but today i had the same problem as Miro. Seems like in this case when you are the host you are not in the list of peers in the collaboration instance. But when you are joining a session you are. Also on host side i only see the joined user and not myself as if in that case the host is not adding itself to the list. |
msujew
force-pushed
the
msujew/fix-session-member-view
branch
from
029f3e7
to
7c30d1e
Compare
|
@jonah-iden I've updated the PR some time ago. Please have another look if you some time. |
jonah-iden
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #36
This fixes the issue of missing users in the session view. The main issue was that we didn't call
onDidUsersChangein our collaboration instance on a few of the peer related requests. Especially important is thepeer/initnotification: Upon joining a room their view was empty - only after another user joins would their view get populated. Now the view is populated instantly.