-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Group sending of datapoints #3
Group sending of datapoints #3
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, some minor hints for potential improvement, but nothing critical.
b3633a4
to
11636c0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ok to me. Did a sanity test and it seemed to work ok
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This currently doesn't work with sdv.databroker.v1
. I think it has to do with the changes introduced to share a Provider
between multiple senders.
My guess is that the issue stems from introducing an Arc<RwLock<<_>>
around the provider. I think it would be better to use a clonable Publisher
that would wrap the underlying Sender
side of the channel that the provider uses to queue up things to publish.
6f99acc
to
fc34e01
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this is good enough now to enable specifying cycle time per signal.. Not really happy with a number of regressions, but lets improve those in follow up PRs
This PR implements the group sending of datapoints by a newly defined json file.
Databroker-perf creates two gRPC channels (one for the provider and one for the subscriber) shared among groups.
Each provider will update its group signal values to the Databroker at the cycle time specified (in milliseconds) in the JSON configuration file provided.
config_group.json file:
Run seconds test parameter implemented instead of iterations parameter since all groups should end at the same exact time.
--detail-output flag added to extend the test result view.
Max number of groups defined to 10.
Check docu for more info: https://github.com/eclipse-kuksa/kuksa-perf/blob/b89e1c906d1d879e99d0dd3e01b2a1f07f9d8e97/README.md
Use first subscribed values to publish correct values and avoid app from blocking