Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add all flags to scanner discovery #158

Merged

Commits on Nov 21, 2022

  1. Bug 571722: Add ALL_FLAGS for scanner discovery

    This change adds the ALL_FLAGS that does not limit tool options to
    those declared as IOption::isForScannerDiscovery when launching the
    compiler to discover compiler built-ins.
    
    This is needed as many other flags, either entered manually in "Other
    flags" or some of the existing flags with checkboxes such as "-ansi",
    "-fPIC", and "-fstack-protector-all" which all affect scanner discovery
    as they can all change what macros are built-in to the compiler.
    
    The current solution has as a drawback that some settings, like -I and -D
    then appear twice. For example in the "Includes" node in the "Project
    Explorer"
    
    My only reservation about this change is if there is an option
    that can be specified successfully at build time, but when used
    at scanner discovery time causes the compiler to fail, or return
    incorrect results. Therefore I have added a new field,
    excludeFromScannerDiscovery to tool options (buildDefinitions
    extension point) that allows tool integrators to always exclude
    a command line option from ALL_FLAGS. I have also added
    a new "Other flags (excluded from discovery)" to the
    "Miscellaneous" tab to allow compiler options to be entered
    by the user.
    jonahgraham committed Nov 21, 2022
    Configuration menu
    Copy the full SHA
    5b08c5d View commit details
    Browse the repository at this point in the history