Merge branch 'dev' into 'main'

Dev + adding tests

See merge request ebi-biows/jdispatcher-viewers!4

.github/workflows/build.yml

@@ -38,6 +38,11 @@ jobs:
       - name: Check code format
         run: npm run format
       #----------------------------------------------
+      # Run tests with Jest
+      #----------------------------------------------
+      - name: Run tests with Jest
+        run: npm test
+      #----------------------------------------------
       # Build Module
       #----------------------------------------------
       - name: Build module

.gitlab-ci.yml

@@ -19,7 +19,7 @@ before_script:
 
 stages:
   - check
-  # - test
+  - test
   # - tag
   # building the ES modules and node CLI (also ES module now, from commonJS)
   - build
@@ -58,6 +58,12 @@ format:
     - npm run format
   allow_failure: false
 
+test:
+  stage: test
+  script:
+    - npm test
+  allow_failure: false
+
 build_module:
   stage: build
   script:

bin/color-utilities.js

@@ -136,6 +136,10 @@ export function getGradientSteps(minEvalue, maxEvalue, minEvalueNotZero, colorSc
  * h, s, v
  */
 export function HSVtoRGB(h, s, v) {
+    // Clamp input values to the expected range [0, 1]
+    h = Math.min(Math.max(h, 0), 1);
+    s = Math.min(Math.max(s, 0), 1);
+    v = Math.min(Math.max(v, 0), 1);
     let r = 0;
     let g = 0;
     let b = 0;

bin/drawing-utilities.js

@@ -574,7 +574,7 @@ export function drawFooterText(renderOptions, topPadding) {
     textObj.evented = true;
     textObj.top = topPadding;
     textObj.left = 225;
-    const copyright = `European Bioinformatics Institute 2006-2022. ` +
+    const copyright = `European Bioinformatics Institute 2006-2024. ` +
         `EBI is an Outstation of the European Molecular Biology Laboratory.`;
     const copyrightText = new fabric.Text(`${copyright}`, textObj);
     return [copyrightText, textObj];

bin/other-utilities.js

@@ -50,18 +50,18 @@ export class ObjectCache {
         }
     }
 }
-function countDecimals(n) {
+export function countDecimals(n) {
     if (Math.floor(n) === n)
         return 0;
     return n.toString().split('.')[1].length || 0;
 }
 export function numberToString(n) {
-    if (Number.isInteger(n)) {
-        return n + '.0';
-    }
-    else if (n < 0.0001 || n > 10000) {
+    if (n < 0.0001 || n > 10000) {
         return n.toExponential(2);
     }
+    else if (Number.isInteger(n)) {
+        return n + '.0';
+    }
     else if (countDecimals(n) > 3) {
         return n.toFixed(3).toString();
     }

dist/jd_viewers_0.0.10.bundle.min.js.LICENSE.txt

@@ -0,0 +1,32 @@
+/*!
+ * The buffer module from node.js, for the browser.
+ *
+ * @author   Feross Aboukhadijeh <https://feross.org>
+ * @license  MIT
+ */
+
+/*! Fabric.js Copyright 2008-2015, Printio (Juriy Zaytsev, Maxim Chernyak) */
+
+/*! http://mths.be/fromcodepoint v0.1.0 by @mathias */
+
+/*! ieee754. BSD-3-Clause License. Feross Aboukhadijeh <https://feross.org/opensource> */
+
+/*! safe-buffer. MIT License. Feross Aboukhadijeh <https://feross.org/opensource> */
+
+/**
+ * @license
+ * Copyright 2017 Google LLC
+ * SPDX-License-Identifier: BSD-3-Clause
+ */
+
+/**
+ * @license
+ * Copyright 2019 Google LLC
+ * SPDX-License-Identifier: BSD-3-Clause
+ */
+
+/**
+ * @license
+ * Copyright 2021 Google LLC
+ * SPDX-License-Identifier: BSD-3-Clause
+ */

jest.config.js

@@ -0,0 +1,8 @@
+export default {
+  preset: 'ts-jest/presets/default-esm',
+  testEnvironment: 'node',
+  extensionsToTreatAsEsm: ['.ts'],
+  transform: {
+    '^.+\\.tsx?$': ['ts-jest', { useESM: true }],
+  },
+};

jest.setup.js

@@ -0,0 +1,2 @@
+const { createCanvas } = require('canvas');
+global.HTMLCanvasElement.prototype.getContext = () => createCanvas(1200, 800).getContext('2d');