Skip to content

Commit

Permalink
Digit arguments ignored for objects created with `marginaleffects::hy…
Browse files Browse the repository at this point in the history
…potheses()` (#1027)

Fixes #1024
  • Loading branch information
strengejacke authored Oct 9, 2024
1 parent 19651d1 commit a7955cf
Show file tree
Hide file tree
Showing 4 changed files with 44 additions and 0 deletions.
5 changes: 5 additions & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,11 @@

* Improved printing for `simulate_parameters()` for models from packages *mclogit*.

## Bug fixes

* Arguments like `digits` etc. were ignored in `model_parameters() for objects
from the *marginaleffects* package.

# parameters 0.22.2

## New supported models
Expand Down
18 changes: 18 additions & 0 deletions R/methods_marginaleffects.R
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,15 @@ model_parameters.marginaleffects <- function(model,
# exponentiate coefficients and SE/CI, if requested
out <- .exponentiate_parameters(out, model = NULL, exponentiate)

# add further information as attributes
out <- .add_model_parameters_attributes(
out,
model = model,
ci = ci,
exponentiate = exponentiate,
...
)

class(out) <- c("parameters_model", "see_parameters_model", class(out))
out
}
Expand Down Expand Up @@ -97,6 +106,15 @@ model_parameters.predictions <- function(model,
# exponentiate coefficients and SE/CI, if requested
out <- .exponentiate_parameters(out, model = NULL, exponentiate)

# add further information as attributes
out <- .add_model_parameters_attributes(
out,
model = model,
ci = ci,
exponentiate = exponentiate,
...
)

class(out) <- c("parameters_model", "see_parameters_model", class(out))
out
}
11 changes: 11 additions & 0 deletions tests/testthat/_snaps/marginaleffects.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
# digits and ci_digits for marginaleffects

Code
out
Output
# Fixed Effects
Parameter | Coefficient | SE | Statistic | p | S | 95% CI
--------------------------------------------------------------------------
10*wt = 0 | -53.4 | 5.6 | -9.6 | < .001 | 69.5 | [-64.4, -42.5]

10 changes: 10 additions & 0 deletions tests/testthat/test-marginaleffects.R
Original file line number Diff line number Diff line change
Expand Up @@ -102,3 +102,13 @@ test_that("model_parameters defaults to FALSE: Issue #916", {
out2 <- model_parameters(pred, exponentiate = FALSE)
expect_equal(out1$Predicted, out2$Predicted, tolerance = 1e-4)
})


test_that("digits and ci_digits for marginaleffects", {
data(mtcars)
skip_if(getRversion() < "4.2.0")
out <- lm(mpg ~ wt, data = mtcars) |>
marginaleffects::hypotheses(hypothesis = "10*wt = 0") |>
model_parameters(digits = 1)
expect_snapshot(out)
})

0 comments on commit a7955cf

Please sign in to comment.