Wrong DFs in model_parameters.fixest

Fixes #892
easystats · Sep 9, 2023 · a131fca · a131fca
1 parent fa44f61
commit a131fca
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 4 deletions.
diff --git a/R/methods_fixest.R b/R/methods_fixest.R
@@ -18,10 +18,10 @@ model_parameters.fixest <- function(model,
                                     ...) {
   # default ci-method, based on statistic
   if (is.null(ci_method)) {
-    if (identical(insight::find_statistic(model), "t-statistic")) {
+    if (identical(insight::find_statistic(model), "t-statistic") && identical(model$method, "feols")) {
       ci_method <- "residual"
     } else {
-      ci_method <- "wald"
+      ci_method <- "normal"
     }
   }
 
@@ -92,8 +92,14 @@ degrees_of_freedom.fixest <- function(model, method = "wald", ...) {
   }
   method <- match.arg(
     tolower(method),
-    choices = c("wald", "residual")
+    choices = c("wald", "residual", "normal")
   )
+
+  # we may have Inf DF, too
+  if (method == "normal") {
+    return(Inf)
+  }
+
   method <- switch(method,
     "wald" = "t",
     "residual" = "resid"

diff --git a/tests/testthat/test-model_parameters.fixest.R b/tests/testthat/test-model_parameters.fixest.R
@@ -13,7 +13,7 @@ test_that("model_parameters.fixest", {
   )
   params <- model_parameters(m, verbose = FALSE)
 
-  expect_equal(c(nrow(params), ncol(params)), c(2, 9))
+  expect_identical(c(nrow(params), ncol(params)), c(2L, 9L))
   expect_equal(params$p, as.vector(fixest::pvalue(m)), tolerance = 1e-3)
   expect_equal(params$df_error[1], as.vector(fixest::degrees_freedom(m, type = "t")), tolerance = 1e-3)
   expect_equal(params$Coefficient, as.vector(coef(m)), tolerance = 1e-3)