Fedex/restapi/shippingprovider #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
May 13, 2024 14:46
… simplicity Updated various properties in FedExShipmentProvider and related classes for better flexibility and simplicity. Made `FreightOnValue` nullable and changed `EncodedLabel` type to byte[]. Added new enum member to `ShippingDocumentType`. Set `ServiceType` and `PackagingType` dynamically. Added `Dimensions`, `LabelPrintingOrientation`, `LabelRotation`, and `CustomerImageUsages` properties. Simplified `RequestedDocumentTypes` and `Bytes` properties. Changed `PaymentType` from `RECIPIENT` to `SENDER`. Updated `FedExShipmentProviderTests` to save labels as PNG and modified the `international` address.
Added `System.Reflection.Emit` namespace to `FedExShipmentProvider.cs` for metadata and MSIL emission. Introduced `EmailNotificationDetail` object to `FedExShipmentProvider` class for detailed email notifications. Updated `PaymentType` to be dynamic based on `shipmentDetails.PaymentType.Name`. Implemented `CancelShipmentAsync` method in `FedExShipmentProvider` class to handle shipment cancellations and log exceptions. Uncommented test lines in `FedExShipmentProviderTests` to include shipment cancellation tests.
This commit enhances the functionality of the FedEx rate provider and related tests. Changes include setting the `AccountNumber` directly in `FedexRateProvider.cs`, adding `StateOrProvinceCode` and `City` properties for `Shipper` and `Recipient` addresses, and setting `PackageSpecialServices` based on the `SignatureRequiredOnDelivery` flag. A condition is added to check for non-US `DestinationAddress` and set `CustomsClearanceDetail` accordingly. In `FedExShipmentProvider.cs`, the `CommercialInvoice` property is now set with `SpecialInstructions`. Lastly, the output line in `FedExRateProviderTests.cs` now includes the full name of the `rateService` type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update FedEx rate and shipment provider and related tests