Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[21817] Improve endpoints display and topic traceability #238

Merged
merged 8 commits into from
Nov 20, 2024
Merged

[21817] Improve endpoints display and topic traceability #238

merged 8 commits into from
Nov 20, 2024

Conversation

Carlosespicur
Copy link
Contributor

@Carlosespicur Carlosespicur commented Nov 15, 2024 •
edited
Loading

Main Changes

  • Fixed a compilation error in docs due to a invalid reference
  • Added new EntityId getters
  • Added an "open menu" calls tracker to allow customizing menu item messages for each monitor panel
  • Refactored EntitiesMenu component to load items dynamically, allowing different options for each entity kind

This PR must be merged after:

@Carlosespicur
Fix cross-reference error in docs
7f0ef09 
Signed-off-by: Carlosespicur <carlosespicur@proton.me>
@Carlosespicur
Rename topic filtering button in left panel
3930e38 
Signed-off-by: Carlosespicur <carlosespicur@proton.me>
@Carlosespicur
Add new getters, refactor EntitiesMenu to allow dynamic load of menu …
e394a8c 
…options & add component tracker for menu messages customization

Signed-off-by: Carlosespicur <carlosespicur@proton.me>
@Carlosespicur Carlosespicur mentioned this pull request Nov 15, 2024
Merged
@Carlosespicur Carlosespicur force-pushed the feature/improve-display-traceability branch from d43743f to 9cd0879 Compare November 15, 2024 12:56
@Carlosespicur
Refs #21817: Uncrustify
6473b99 
Signed-off-by: Carlosespicur <carlosespicur@proton.me>
@Carlosespicur Carlosespicur force-pushed the feature/improve-display-traceability branch from 9cd0879 to 6473b99 Compare November 15, 2024 12:58
@Carlosespicur
Refs #21817: Change ids in EntitiesMenu
f8c848d 
Signed-off-by: Carlosespicur <carlosespicur@proton.me>
@Carlosespicur
Refs #21817: Fix highlighting bug in EntitesMenu options
661b341 
Signed-off-by: Carlosespicur <carlosespicur@proton.me>
@Carlosespicur Carlosespicur mentioned this pull request Nov 20, 2024
Merged
@Carlosespicur
Refs #21817: Apply suggested changes
c0bc816 
Signed-off-by: Carlosespicur <carlosespicur@proton.me>
@Carlosespicur Carlosespicur force-pushed the feature/improve-display-traceability branch from aa9186a to c893c60 Compare November 20, 2024 13:53
@Carlosespicur
Refs #21817: Fix CI error in documentation tests
a5da79d 
Signed-off-by: Carlosespicur <carlosespicur@proton.me>
@Carlosespicur Carlosespicur force-pushed the feature/improve-display-traceability branch from c893c60 to a5da79d Compare November 20, 2024 14:08
depink5
depink5 approved these changes Nov 20, 2024
View reviewed changes
Copy link

@depink5 depink5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI 🎉

@depink5 depink5 self-requested a review November 20, 2024 14:37
rsanchez15
rsanchez15 requested changes Nov 20, 2024
View reviewed changes
Copy link
Collaborator

@rsanchez15 rsanchez15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've seen some debug traces in the code that are printed even in release mode. Could you please review this a remove them in this PR?

@rsanchez15
Copy link
Collaborator

I've seen some debug traces in the code that are printed even in release mode. Could you please review this a remove them in this PR?

There will be a new PR in the statistics backend fixing this issue

@rsanchez15 rsanchez15 merged commit 6c9a9d1 into main Nov 20, 2024
14 checks passed
@rsanchez15 rsanchez15 deleted the feature/improve-display-traceability branch November 20, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@depink5 depink5 depink5 approved these changes

@rsanchez15 rsanchez15 rsanchez15 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Carlosespicur @rsanchez15 @depink5