Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add storage feature #58

Merged
merged 6 commits into from
Jan 12, 2024
Merged

feat: add storage feature #58

merged 6 commits into from
Jan 12, 2024

Conversation

omdxp
Copy link
Member

@omdxp omdxp commented Jan 9, 2024

Type of change

  • New feature (non-breaking change which adds functionality)

@omdxp omdxp requested a review from ZibanPirate January 9, 2024 19:55
@omdxp omdxp self-assigned this Jan 9, 2024
@github-actions github-actions bot added the rust label Jan 9, 2024
ZibanPirate
ZibanPirate requested changes Jan 10, 2024
View reviewed changes
Copy link
Member

@ZibanPirate ZibanPirate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work!

left few comments...

.github/workflows/rust-checks.yml Outdated Show resolved Hide resolved
rust/src/lib.rs Outdated Show resolved Hide resolved
rust/src/api/storage.rs Outdated Show resolved Hide resolved
rust/src/node/model.rs Outdated Show resolved Hide resolved
rust/src/node/model.rs Outdated Show resolved Hide resolved
rust/src/node/model.rs Outdated Show resolved Hide resolved
rust/src/node/model.rs Outdated Show resolved Hide resolved
rust/src/api/get_node_by_path.rs Outdated Show resolved Hide resolved
rust/src/api/get_node_by_path.rs Outdated Show resolved Hide resolved
rust/src/api/get_node_by_path.rs Outdated Show resolved Hide resolved
@omdxp omdxp force-pushed the add-storage-feature branch 2 times, most recently from 44625c8 to 34d4f56 Compare January 12, 2024 17:14
ZibanPirate
ZibanPirate requested changes Jan 12, 2024
View reviewed changes
Copy link
Member

@ZibanPirate ZibanPirate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i quickly schemed it, left few more comments

.github/workflows/rust-checks.yml Show resolved Hide resolved
rust/Cargo.toml Outdated Show resolved Hide resolved
rust/src/node/model.rs Outdated Show resolved Hide resolved
@omdxp omdxp merged commit 7a08d4d into main Jan 12, 2024
4 checks passed
@omdxp omdxp deleted the add-storage-feature branch January 12, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZibanPirate ZibanPirate ZibanPirate approved these changes

Assignees

@omdxp omdxp

Labels
rust
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@omdxp @ZibanPirate