Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: rust: make features mutually exclusive #104

Merged
merged 3 commits into from
Nov 21, 2024
Merged

fix: rust: make features mutually exclusive #104

merged 3 commits into from
Nov 21, 2024

Conversation

ZibanPirate
Copy link
Member

@ZibanPirate ZibanPirate commented Nov 21, 2024 •
edited
Loading

Note: blocker for #60

Description

crate features should be able to coexist together with no conflict, as stated by cargo docs:

https://doc.rust-lang.org/cargo/reference/features.html#mutually-exclusive-features

What changed:

  • split static vs storage features into their own modules.
  • conditionally export each module based on status of their respective features
  • added additional tests for all features together (cargo test --all-features)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

@github-actions github-actions bot added the rust label Nov 21, 2024
@ZibanPirate ZibanPirate marked this pull request as ready for review November 21, 2024 16:37
omdxp
omdxp approved these changes Nov 21, 2024
View reviewed changes
Copy link
Member

@omdxp omdxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's clearer now 🔍

@ZibanPirate ZibanPirate merged commit d842e2e into main Nov 21, 2024
4 checks passed
@ZibanPirate ZibanPirate deleted the fix/rust/make-features-mutually-exclusive branch November 21, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omdxp omdxp omdxp approved these changes

Assignees
No one assigned
Labels
rust
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ZibanPirate @omdxp