fix(sequencers): incorrect sorting mechanism allows manipulation of proposer selection #1292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omritoptix
requested changes
Oct 10, 2024
| } | ||
| // validate bond requirement | ||
| minBond := k.GetParams(ctx).MinBond | ||
| if !msg.Bond.IsGTE(minBond) { |
There was a problem hiding this comment.
I see we removed the check if the bond denom is the same as the minBond denom. in that case where do we enforce someone doesn't bond other token denom vs the bond denom defined?
There was a problem hiding this comment.
it's checked in IsGTE
// IsGTE returns true if they are the same type and the receiver is
// an equal or greater value
| @@ -55,45 +49,63 @@ func (suite *SequencerTestSuite) TestMinBond() { | |||
| bond: sdk.NewCoin(bond.Denom, bond.Amount.Quo(sdk.NewInt(2))), | |||
| expectedError: types.ErrInsufficientBond, | |||
| }, | |||
| { | |||
| name: "wrong bond denom", | |||
There was a problem hiding this comment.
also this test seems to test the wrong thing - i.e fail on invalid coin denom vs valid but not what we expected (i.e wrong denom).
There was a problem hiding this comment.
changed the test a bit
omritoptix
approved these changes
Oct 11, 2024
omritoptix
deleted the
mtsitrin/1291-incorrect-sorting-mechanism-allows-manipulation-of-proposer-selection
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #1291
This PR does the following:
MinBondparam to be > 0 (instead >= 0 currently)