improved UT

dymensionxyz · Oct 11, 2024 · a64c2cf · a64c2cf
1 parent b3288d4
commit a64c2cf
Showing 1 changed file with 7 additions and 9 deletions.
diff --git a/x/sequencer/keeper/msg_server_create_sequencer_test.go b/x/sequencer/keeper/msg_server_create_sequencer_test.go
@@ -1,10 +1,12 @@
 package keeper_test
 
 import (
+	"errors"
 	"fmt"
 	"reflect"
 	"time"
 
+	errorsmod "cosmossdk.io/errors"
 	codectypes "github.com/cosmos/cosmos-sdk/codec/types"
 	"github.com/cosmos/cosmos-sdk/crypto/keys/ed25519"
 	sdk "github.com/cosmos/cosmos-sdk/types"
@@ -25,6 +27,8 @@ const (
 var bond = types.DefaultParams().MinBond
 
 func (suite *SequencerTestSuite) TestMinBond() {
+	panicErr := errors.New("panic")
+
 	testCases := []struct {
 		name          string
 		requiredBond  sdk.Coin
@@ -37,12 +41,6 @@ func (suite *SequencerTestSuite) TestMinBond() {
 			bond:          bond,
 			expectedError: nil,
 		},
-		{
-			name:          "Bad denom",
-			requiredBond:  bond,
-			bond:          sdk.NewCoin("invalid", sdk.NewInt(100)),
-			expectedError: types.ErrInvalidCoinDenom,
-		},
 		{
 			name:          "Insufficient bond",
 			requiredBond:  bond,
@@ -52,8 +50,8 @@ func (suite *SequencerTestSuite) TestMinBond() {
 		{
 			name:          "wrong bond denom",
 			requiredBond:  bond,
-			bond:          sdk.NewCoin("eth", bond.Amount),
-			expectedError: types.ErrInvalidCoinDenom,
+			bond:          sdk.NewCoin("nonbonddenom", bond.Amount),
+			expectedError: panicErr,
 		},
 	}
 
@@ -87,7 +85,7 @@ func (suite *SequencerTestSuite) TestMinBond() {
 			func() {
 				defer func() {
 					if r := recover(); r != nil {
-						createErr = fmt.Errorf("panic in CreateSequencer: %v", r)
+						createErr = errorsmod.Wrapf(panicErr, "panic: %v", r)
 					}
 				}()
 				_, createErr = suite.msgServer.CreateSequencer(suite.Ctx, &sequencerMsg1)