fix: error undefined stringInputs when google not send all input fiel…

…ds, fixes #12
dyaskur · Aug 27, 2023 · 33b8174 · 33b8174
1 parent c96a49b
commit 33b8174
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 20 deletions.
diff --git a/src/helpers/state.ts b/src/helpers/state.ts
@@ -28,14 +28,13 @@ export function getStateFromCard(event: chatV1.Schema$DeprecatedEvent) {
 
 export function getConfigFromInput(formValues: PollFormInputs) {
   const state: PollConfig = {topic: '', choices: []};
-
-  state.topic = formValues.topic.stringInputs!.value![0]!.trim();
-  state.anon = formValues.is_anonymous.stringInputs!.value![0] === '1';
-  state.optionable = formValues.allow_add_option.stringInputs!.value![0] === '1';
-  state.type = parseInt(formValues.type.stringInputs!.value![0]) as ClosableType;
+  state.topic = formValues.topic.stringInputs!.value![0]!.trim() ?? '';
+  state.anon = formValues.is_anonymous?.stringInputs!.value![0] === '1';
+  state.optionable = formValues.allow_add_option?.stringInputs!.value![0] === '1';
+  state.type = parseInt(formValues.type?.stringInputs!.value![0] ?? '1') as ClosableType;
 
   for (let i = 0; i < MAX_NUM_OF_OPTIONS; ++i) {
-    const choice = formValues[`option${i}`]!.stringInputs!.value![0]!.trim();
+    const choice = formValues[`option${i}`]?.stringInputs!.value![0]!.trim();
     if (choice) {
       state.choices.push(choice);
     }

diff --git a/tests/action-handler.test.ts b/tests/action-handler.test.ts
@@ -256,7 +256,6 @@ describe('startPoll', () => {
         invokedFunction: 'start_poll',
         formInputs: {
           topic: {stringInputs: {value: ['Topic']}},
-          is_anonymous: {stringInputs: {value: ['0']}},
           allow_add_option: {stringInputs: {value: ['0']}},
           type: {stringInputs: {value: ['0']}},
           option0: {stringInputs: {value: ['Yay']}},
@@ -265,10 +264,6 @@ describe('startPoll', () => {
           option3: {stringInputs: {value: ['']}},
           option4: {stringInputs: {value: ['']}},
           option5: {stringInputs: {value: ['No Way']}},
-          option6: {stringInputs: {value: ['']}},
-          option7: {stringInputs: {value: ['']}},
-          option8: {stringInputs: {value: ['']}},
-          option9: {stringInputs: {value: ['']}},
         },
       },
       user: {displayName: 'User'},
@@ -316,15 +311,6 @@ describe('startPoll', () => {
           allow_add_option: {stringInputs: {value: ['1']}},
           type: {stringInputs: {value: ['1']}},
           option0: {stringInputs: {value: ['Option 1']}},
-          option1: {stringInputs: {value: ['']}},
-          option2: {stringInputs: {value: ['']}},
-          option3: {stringInputs: {value: ['']}},
-          option4: {stringInputs: {value: ['']}},
-          option5: {stringInputs: {value: ['']}},
-          option6: {stringInputs: {value: ['']}},
-          option7: {stringInputs: {value: ['']}},
-          option8: {stringInputs: {value: ['']}},
-          option9: {stringInputs: {value: ['']}},
         },
       },
     };