Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add accessibility statement #508 #509

Merged
merged 2 commits into from
Jan 25, 2024

Conversation

TatianaBurek
Copy link
Collaborator

Pull Request Testing

  • Describe testing already performed for these changes:
    the fix is installed on dakota : http://dakota.rap.ucar.edu:8080/metviewer_dev/metviewer1.jsp
    The statement is placed on the upper left corner below the version number

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes or No]

  • Do these changes include sufficient testing updates? [Yes or No]

  • Will this PR result in changes to the test suite? [Yes or No]

    If yes, describe the new output and/or changes to the existing output:

  • Please complete this pull request review by [Fill in date].

Pull Request Checklist

See the METplus Workflow for details.

  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s)
    Select: Organization level software support Project or Repository level development cycle Project
    Select: Milestone as the version that will include these changes
  • After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@TatianaBurek TatianaBurek added this to the METviewer-6.0.0 milestone Jan 5, 2024
@TatianaBurek TatianaBurek linked an issue Jan 5, 2024 that may be closed by this pull request
21 tasks
Copy link
Contributor

@JohnHalleyGotway JohnHalleyGotway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve of these changes.

Tatiana, sorry for losing track of this PR review request. As we discussed during the METplus Analysis tools meeting on Jan 24th, 2024, I have mixed feelings about implementing this change directly in the METviewer repository.

It's awkward coupling the METviewer web application so closely to UCAR, as an organization. I certainly do not object to the web accessibility statement in and of itself. It's just that METviewer will be deployed at other institutions (e.g. AirForce, MetOffice, Australian BOM, NOAA). If users follow that link, they may send an email to help@ucar.edu about their experience on a website not actually housed at NCAR.

I agree that just adding it to the repo is the easier option rather than making it a custom installation step. So I'm fine with you merging this change. If it comes up in the future, we may want to make it an installation time option instead.

Checking http://dakota.rap.ucar.edu:8080/metviewer_dev/metviewer1.jsp does look fine with Chrome and Safari on my Mac laptop:
Screenshot 2024-01-24 at 4 01 08 PM

However the one currently deployed at http://dtcenter.ucar.edu/met/metviewer/metviewer1.jsp doesn't render well. Presumably this PR will fix that:
Screenshot 2024-01-24 at 4 03 41 PM

@TatianaBurek TatianaBurek merged commit e013b60 into develop Jan 25, 2024
2 checks passed
@TatianaBurek TatianaBurek deleted the issue_508_accessibility_statement branch January 25, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🏁 Done
Development

Successfully merging this pull request may close these issues.

add accessibility statement
2 participants