Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement: Provide Docker images that contain all METplus components #2682

Closed
24 tasks
georgemccabe opened this issue Sep 9, 2024 · 2 comments · Fixed by #2733
Closed
24 tasks

Enhancement: Provide Docker images that contain all METplus components #2682

georgemccabe opened this issue Sep 9, 2024 · 2 comments · Fixed by #2733
Assignees
@georgemccabe
Labels
component: build process Build process issue component: docker priority: high High Priority required: FOR OFFICIAL RELEASE Required to be completed in the official release for the assigned milestone type: enhancement Improve something that it is currently doing
Milestone
METplus-6.0.0

Comments

@georgemccabe
Copy link
Collaborator

georgemccabe commented Sep 9, 2024 •
edited
Loading

Currently the dtcenter/metplus images, e.g. 6.0.0, contain MET and METplus wrappers.

Describe the Enhancement

Consider providing images on DockerHub that also contain METdataio/METcalcpy/METplotpy and its requirements.

Time Estimate

Estimate the amount of work required here.
Issues should represent approximately 1 to 3 days of work.

Sub-Issues

Consider breaking the enhancement down into sub-issues.

  • Add a checkbox for each sub-issue here.

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

I-WRF

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Review default alert labels
  • Select component(s)
  • Select priority
  • Select requestor(s)

Milestone and Projects

  • Select Milestone as a METplus-Wrappers-X.Y.Z version, Consider for Next Release, or Backlog of Development Ideas
  • For a METplus-Wrappers-X.Y.Z version, select the METplus-Wrappers-X.Y.Z Development project

Define Related Issue(s)

Consider the impact to the other METplus components.

Enhancement Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Add any new Python packages to the METplus Components Python Requirements table.
  • For any new datasets, an entry to the METplus Verification Datasets Guide.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Development issue
    Select: Milestone as the next official version
    Select: METplus-Wrappers-X.Y.Z Development project for development toward the next official release
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@georgemccabe georgemccabe added type: enhancement Improve something that it is currently doing alert: NEED MORE DEFINITION Not yet actionable, additional definition required alert: NEED ACCOUNT KEY Need to assign an account key to this issue alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle labels Sep 9, 2024
@georgemccabe georgemccabe added this to the METplus-6.1.0 milestone Sep 9, 2024
@JohnHalleyGotway JohnHalleyGotway mentioned this issue Sep 9, 2024
Open
20 tasks
@georgemccabe georgemccabe self-assigned this Oct 4, 2024
@georgemccabe georgemccabe moved this from 🟢 Ready to 🏗 In progress in METplus-Wrappers-6.0.0 Development Oct 4, 2024
@georgemccabe georgemccabe added priority: high High Priority component: build process Build process issue required: FOR OFFICIAL RELEASE Required to be completed in the official release for the assigned milestone component: docker and removed alert: NEED MORE DEFINITION Not yet actionable, additional definition required alert: NEED ACCOUNT KEY Need to assign an account key to this issue alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle labels Oct 4, 2024
georgemccabe added a commit that referenced this issue Oct 16, 2024
@georgemccabe
per #2682, created METplus component version lookup table and functio…
71a6f6a 
…ns to get formatted version of requested components
@georgemccabe georgemccabe mentioned this issue Oct 17, 2024
Merged
16 tasks
@georgemccabe georgemccabe linked a pull request Oct 17, 2024 that will close this issue
Feature #2682 Component version lookup #2733
Merged
16 tasks
georgemccabe added a commit that referenced this issue Oct 18, 2024
@georgemccabe
Feature #2682 Component version lookup (#2733)
86327e0 
* per #2714, deprecate master_metplus.py

* exclude metplus/scripts from SonarQube scan to prevent incorrect duplicate code error since script lives in ush

* added Dockerfile to build image with MET/METplus and METplus Analysis Python packages

* start of script to get versions of METplus components

* per #2682, created METplus component version lookup table and functions to get formatted version of requested components

* add descriptions for tests

* add update information and made script callable

* made script executable

* add workflow to trigger on release and create dtcenter/metplus and dtcenter/metplus-analysis Docker images

* add scripts used by new workflow

* removed build hook scripts since we will be building images via GHA

* change logic to get MET version using component version script instead of build hook file that just adds 6 to major version

* add missing shebang

* make script callable directly and make output component a required input

* pass LATEST_TAG to push script

* ensure only 1st line of version file is read to avoid newline

* turn on use case to test

* turn off use case
@georgemccabe
Copy link
Collaborator Author

Changes to support the automatic creation of the dtcenter/metplus-analysis image was added in PR #2733. I am keeping this issue open until I can confirm that the workflow triggered by a release works as expected.

@georgemccabe
Copy link
Collaborator Author

I confirmed that the beta6 release triggered the creation of the dtcenter/metplus and dtcenter/metplus-analysis images on DockerHub.

I would like to confirm that the official release images 6.0.0 are created properly, so I created #2756 which I assigned to the beta1 cycle of 6.1.0 to check on this after the 6.0.0 release has been created.

@github-project-automation github-project-automation bot moved this from 🏗 In progress to 🏁 Done in METplus-Wrappers-6.0.0 Development Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@georgemccabe georgemccabe

Labels
component: build process Build process issue component: docker priority: high High Priority required: FOR OFFICIAL RELEASE Required to be completed in the official release for the assigned milestone type: enhancement Improve something that it is currently doing
Projects
METplus-Wrappers-6.0.0 Development
Status: 🏁 Done
Milestone
METplus-6.0.0
Development

Successfully merging a pull request may close this issue.

Feature #2682 Component version lookup dtcenter/METplus
1 participant
@georgemccabe