Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a Python visualization image for WRF output and define plotting script(s) for Hurricane Matthew test case #50

Open
20 tasks
jaredalee opened this issue Feb 23, 2024 · 5 comments
Assignees
Labels
component: plotting Continuous integration and deployment issues component: testing Software testing issues deliverable 1.2 Generate containers type: task An actionable item of work
Milestone

Comments

@jaredalee
Copy link
Contributor

Describe the Task

Create sample Python visualization script(s) to accompany the Hurricane Matthew test case and then be containerized. Plotting a few WRF fields and some verification results (using results of #49) will likely be useful for demonstration.

Time Estimate

Estimate the amount of work required here.
Issues should represent approximately 1 to 3 days of work.

Sub-Issues

Consider breaking the task down into sub-issues.

  • Add a checkbox for each sub-issue here.

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

7790013

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Select Repository and/or Organization level Project(s) or add alert: NEED PROJECT ASSIGNMENT label
  • Select Milestone as the next official version or Future Versions

Task Checklist

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Development issues
    Select: Repository level development cycle Project for the next official release
    Select: Milestone as the next official version
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@jaredalee jaredalee added component: plotting Continuous integration and deployment issues component: testing Software testing issues deliverable 1.2 Generate containers type: task An actionable item of work labels Feb 23, 2024
@jaredalee jaredalee added this to the I-WRF 0.2.0 milestone Feb 23, 2024
@jaredalee jaredalee self-assigned this Feb 23, 2024
@jaredalee
Copy link
Contributor Author

I have written a Python script to make some plots of WRF output from the Hurricane Matthew case, testing it on WRF output I generated outside of any container. Next I need to work on containerizing the script and the relevant Python environment.

@JohnHalleyGotway JohnHalleyGotway changed the title Create visualization script(s) for Hurricane Matthew test case Create a Python visualization image for WRF output and define plotting script(s) for Hurricane Matthew test case Jul 19, 2024
@JohnHalleyGotway JohnHalleyGotway self-assigned this Jul 19, 2024
@jaredalee
Copy link
Contributor Author

I just uploaded the main Python script, another Python script with necessary functions, and a README to https://github.com/NCAR/i-wrf/tree/feature/50-python-plotting/use_cases/Hurricane_Matthew/Visualization. There may be a few more modifications that get made to the scripts, but they're functional as long as the directory where the wrfout files live is provided on the command line.

@JohnHalleyGotway
Copy link
Contributor

JohnHalleyGotway commented Sep 9, 2024

Met on Sept 9, 2024 for a working meeting to make progress.

Considered where the Python visualization functionality should live. Options are:

  • Could provide a light-weight, stand-alone wrf-vis image to plot the WRF output.
  • Or could call these plotting scripts via the METplus container.

For the latter, we'd need to add a Dockerfile for METplus to pull a tagged version of METplus, layer on dependencies for METplotpy, and the run the WRF visualization scripts via the UserScript (depends on Cartopy).

Although rather than doing this in the I-WRF repository, perhaps METplus itself should provide this fully integrated METplus environment? Consider updating the dtcenter/metplus Docker repository (https://hub.docker.com/r/dtcenter/metplus) to provide images tagged as:

Based on directory structure in branch feature/40-build-wrf-container, recommend placing this METplus Dockerfile in docker/METplus/Dockerfile.

For the time being, this new Dockerfile will pull the tagged METplus image along with the METplus Analysis tools. Once a "fully-loaded" METplus image is actually available, revise the logic of this Dockerfile.

Also recommend stripping out as much content as possible from this image to keep it lean.

georgemccabe added a commit that referenced this issue Oct 11, 2024
…at includes METplotpy, METcalcpy, METdataio, and wrf python packages. Mount the Hurricane Matthew Visualization directory so the plotting scripts can be found. The WRF plotting script is called from the METplus use case run
georgemccabe added a commit that referenced this issue Oct 15, 2024
* Initial WRF plotting script, functions, and README for the Hurricane Matthew case.

* add Dockerfile to create iwrf-metplus image and update instructions to use that container

* make script executable

* create directory containing output file if it does not already exist

* change default input and output directories to use paths assumed in Docker container

* mount directory containing WRF plotting script to container

* run WRF plotting script as part of METplus use case

* Per #50, update instructions to use I-WRF METplus Docker container that includes METplotpy, METcalcpy, METdataio, and wrf python packages. Mount the Hurricane Matthew Visualization directory so the plotting scripts can be found. The WRF plotting script is called from the METplus use case run

* remove commented code

* remove characters that should not be rendered in the docs

* cleanup usage statement

* Per request on @Trumbore on pull request review, updated WRF log output to include updated content.

---------

Co-authored-by: Jared A. Lee <jaredlee@ucar.edu>
Co-authored-by: John Halley Gotway <johnhg@ucar.edu>
@georgemccabe
Copy link
Contributor

@jaredalee, can we close this issue since the changes from #66 were merged? Or should we include plotting of MET output as part of this issue?

@jaredalee
Copy link
Contributor Author

@georgemccabe, in the issue description above as currently written, we mention that some plots of the METplus stats are envisioned to be part of this issue. So either we should tweak the issue description to focus solely on the WRF output plots and close this issue (along with potentially creating a new issue specific to plots of METplus output), or keep it open until the METplotpy script is considered done-enough for the purposes of this Matthew case and then committed. It doesn't matter much to me which way we go, but it is always nice to be able to close an issue.

georgemccabe added a commit that referenced this issue Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: plotting Continuous integration and deployment issues component: testing Software testing issues deliverable 1.2 Generate containers type: task An actionable item of work
Projects
None yet
Development

No branches or pull requests

3 participants