Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature internal 57 logging remaining #468

Merged
merged 19 commits into from
Oct 1, 2024

Conversation

bikegeek
Copy link
Collaborator

@bikegeek bikegeek commented Sep 30, 2024

Pull Request Testing

  • Describe testing already performed for these changes:

    Remaining plots that needed logging in the METplotpy/metplotpy/plots directory:

  • skew T

  • polar plot

  • scatter plot

NOTE: The MaKEMaKI plot and vertical interpolation plots have code that resides in the METplotpy/metplotpy/contributed directory and will not be addressed in this release.

  • on host 'seneca', using the mp_analysis_env conda environment (Python 3.1 and packages specified in the requirements.txt file):

    skew T plot

  • Generated a skew T log P plot using the data in the METplotpy/metplotpy/plots/skew_t/data directory and verified that the log file was produced (METplotpy/metplotpy/plots/skew_t/logs/tcdiags_skewt.log)
    

    polar ice plot

  •  Generated the polar ice plot via the polar_ice_plot.py and verified the log file is created and contains the expected content  (METplotpy/metplotpy/plots/polar_plot/logs/polar_log.txt)
    

    scatter plot

  •  Generated the scatter plot (deprecated version) using the custom_scatter.yaml file and data in the METplotpy/test/scatter directory. Verified the log file is generated and contains the expected content (METplotpy/test/scatter/scatter_log.txt)
    
  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

    log onto 'seneca' and verify logs are present and have content needed by AF STIG:

    skew T: /d1/personal/mwin/feature_internal_56_METplotpy_remaining_logging/METplotpy/metplotpy/plots/skew_t/log/tc_diags_skewt.log

    polar ice: /d1/personal/mwin/feature_internal_56_METplotpy_remaining_logging/METplotpy/metplotpy/plots/polar_plot/logs/polar_log.txt

    scatter: /d1/personal/mwin/feature_internal_56_METplotpy_remaining_logging/METplotpy/test/scatter/scatter_log.txt

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [NA]

  • Do these changes include sufficient testing updates? [NA]

  • Will this PR result in changes to the test suite? [No]

    If yes, describe the new output and/or changes to the existing output:

  • Do these changes introduce new SonarQube findings? [No]

    If yes, please describe:

  • Please complete this pull request review by [Earliest convenience for beta6 release].

Pull Request Checklist

See the METplus Workflow for details.

  • Add any new Python packages to the METplus Components Python Requirements table.
  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s) and Development issue
    Select: Milestone as the version that will include these changes
    Select: Coordinated METplus-X.Y Support project for bugfix releases or METplotpy-X.Y.Z Development project for official releases
  • After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@bikegeek bikegeek marked this pull request as ready for review October 1, 2024 19:25
@jprestop jprestop added this to the METplotpy-3.0.0 milestone Oct 1, 2024
Co-authored-by: Julie Prestopnik <jpresto@ucar.edu>
Copy link
Contributor

@jprestop jprestop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for all of your work on this task, @bikegeek. Before the minor change, I noted that all tests passed, so I expect them to pass again. Thank you for the paths to your log files - it made it easy for me. I verified the presence of the user ID/name, timestamp, start and end times, and the method being executed to the log output for each METplotpy run. I approve this request.

@bikegeek bikegeek merged commit 66768ef into develop Oct 1, 2024
7 checks passed
@bikegeek bikegeek deleted the feature_internal_57_logging_remaining branch October 1, 2024 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🏁 Done
Development

Successfully merging this pull request may close these issues.

2 participants