-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix 391 fixed values #392
Conversation
…pected plot, and expected data points
…when R was in use or a more simplified format for defining the fixed_vars_vals_input setting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The METviewer test that include grouping, Aggegation statistic and EE failed on dakota:
/d3/projects/METViewer/METviewer_py3.10.4/bin/python /d3/projects/METViewer/METplotpy/metplotpy/plots/line/line.py /opt/vxwww/tomcat/webapps/metviewer_output_dev//data//plot_20231013_180341.yaml
expr cannot be an empty string
plot_20231013_195042.data.txt The new error message:
|
Error fixed- was calling logging when logger is not available in METplotpy's util module. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Manual tests with METviewer passed
Pull Request Testing
Describe testing already performed for these changes:
on host 'seneca', using the /d1/personal/mwin/miniconda3/envs/metplus_analysis_env environment
ran tests under METplotpy/test/line
Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
verify pytests pass in your own work space
verify plotting works when using METviewer
Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes ]
updated the custom_config.yaml file so in the User's Guide, the simpler format for setting the fixed_vars_vals_input is used
Do these changes include sufficient testing updates? [Yes ]
added tests for the query logic in the utils.py (METplotpy) and for the line tests
Will this PR result in changes to the test suite? [No]
If yes, describe the new output and/or changes to the existing output:
Please complete this pull request review by [At earliest convenience].
Pull Request Checklist
See the METplus Workflow for details.
Select: Reviewer(s)
Select: Organization level software support Project or Repository level development cycle Project
Select: Milestone as the version that will include these changes