Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix 391 fixed values #392

Merged
merged 13 commits into from
Oct 16, 2023
Merged

Bugfix 391 fixed values #392

merged 13 commits into from
Oct 16, 2023

Conversation

bikegeek
Copy link
Collaborator

Pull Request Testing

  • Describe testing already performed for these changes:

  • on host 'seneca', using the /d1/personal/mwin/miniconda3/envs/metplus_analysis_env environment

  • ran tests under METplotpy/test/line

    • test_line_plot.py
    • test_line_groups_plot.py
  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

  • verify pytests pass in your own work space

  • verify plotting works when using METviewer

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes ]

  • updated the custom_config.yaml file so in the User's Guide, the simpler format for setting the fixed_vars_vals_input is used

  • Do these changes include sufficient testing updates? [Yes ]

  • added tests for the query logic in the utils.py (METplotpy) and for the line tests

  • Will this PR result in changes to the test suite? [No]

    If yes, describe the new output and/or changes to the existing output:

  • Please complete this pull request review by [At earliest convenience].

Pull Request Checklist

See the METplus Workflow for details.

  • Add any new Python packages to the METplus Components Python Requirements table.
  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s)
    Select: Organization level software support Project or Repository level development cycle Project
    Select: Milestone as the version that will include these changes
  • After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@bikegeek bikegeek added this to the METplotpy-3.0.0 milestone Oct 13, 2023
@TatianaBurek TatianaBurek linked an issue Oct 13, 2023 that may be closed by this pull request
23 tasks
Copy link
Collaborator

@TatianaBurek TatianaBurek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The METviewer test that include grouping, Aggegation statistic and EE failed on dakota:

/d3/projects/METViewer/METviewer_py3.10.4/bin/python /d3/projects/METViewer/METplotpy/metplotpy/plots/line/line.py /opt/vxwww/tomcat/webapps/metviewer_output_dev//data//plot_20231013_180341.yaml
expr cannot be an empty string

@TatianaBurek
Copy link
Collaborator

plot_20231013_195042.data.txt
plot_20231013_195042.yaml.txt

The new error message:

Traceback (most recent call last):
  File "/d3/projects/METViewer/METplotpy/metplotpy/plots/line/line.py", line 885, in <module>
    main()
  File "/d3/projects/METViewer/METplotpy/metplotpy/plots/line/line.py", line 874, in main
    plot = Line(docs)
  File "/d3/projects/METViewer/METplotpy/metplotpy/plots/line/line.py", line 98, in __init__
    self.series_list = self._create_series(self.input_df)
  File "/d3/projects/METViewer/METplotpy/metplotpy/plots/line/line.py", line 156, in _create_series
    series_obj = LineSeries(self.config_obj, i, input_data, series_list, name)
  File "/d3/projects/METViewer/METplotpy/metplotpy/plots/line/line_series.py", line 48, in __init__
    super().__init__(config, idx, input_data, y_axis)
  File "/d3/projects/METViewer/METplotpy/metplotpy/plots/series.py", line 72, in __init__
    self.series_points = self._create_series_points()
  File "/d3/projects/METViewer/METplotpy/metplotpy/plots/line/line_series.py", line 139, in _create_series_points
    query_string = metplotpy.plots.util.create_query(self.input_data,
  File "/d3/projects/METViewer/METplotpy/metplotpy/plots/util.py", line 387, in create_query
    logging.INFO(
TypeError: 'int' object is not callable

@bikegeek
Copy link
Collaborator Author

Error fixed- was calling logging when logger is not available in METplotpy's util module.

Copy link
Collaborator

@TatianaBurek TatianaBurek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manual tests with METviewer passed

@bikegeek bikegeek merged commit 1c14aec into develop Oct 16, 2023
5 checks passed
@bikegeek bikegeek deleted the bugfix_391_fixed_values branch October 16, 2023 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

Bugfix Inconsistency with generating plot in METviewer vs command line
3 participants