Add md5 hash property to GSPath (#483) #490
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: added md5_hash property in GSClient._get_metadata, added md5 property inside GSPath * docs: update supported methods and properties table in root README * chore: running make format * feat: updating code since linter wouldnt let me do it all in one line like the etag property * chore: rename variable to match the variable naming in GSPath.stat() * feat: update LocalGSPath to mimic local/implementations/azure.py for md5 property * feat: updating MockBlob to include md5_hash property * docs: updated history.md * chore: reverting to pre PEP604 syntax * test: added md5 test case, update MockBlob to take its value from an environment variable * chore: applying format and lint
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #490 +/- ##
========================================
- Coverage 94.4% 93.1% -1.4%
========================================
Files 23 23
Lines 1776 1785 +9
========================================
- Hits 1678 1663 -15
- Misses 98 122 +24
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Live tests for #483