Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use variable for client schemes, allowing override #467

Merged

Commits on Aug 31, 2024

  1. use variable for client schemes, allowing override

    This change is intended to make the default client implementations
    more flexible so that their scheme can be customized. This can be
    useful in scenarios where a subclass wants to implement a custom
    scheme on e.g. a S3 compatible API [1] but with a custom scheme
    so that the default S3 access is still also available.
    
    [1] https://cloudpathlib.drivendata.org/stable/authentication/#accessing-custom-s3-compatible-object-stores
    
    The tests have been updated to include a new s3-like rig which uses the
    new scheme override functionality.
    kujenga committed Aug 31, 2024
    Configuration menu
    Copy the full SHA
    54c37b2 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2024

  1. use single cloud_prefix

    kujenga committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    1b3f153 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3cf711a View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2024

  1. Configuration menu
    Copy the full SHA
    2cec1a6 View commit details
    Browse the repository at this point in the history
  2. update custom scheme tests to utilize pytest fixture

    This isolates the implementation in response to PR feedback:
    drivendataorg#467 (comment)
    kujenga committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    147db5b View commit details
    Browse the repository at this point in the history