-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial ADLS gen2 support #453
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #453 +/- ##
========================================
+ Coverage 93.6% 94.2% +0.6%
========================================
Files 23 23
Lines 1665 1728 +63
========================================
+ Hits 1559 1629 +70
+ Misses 106 99 -7
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of typos/tweaks
@M0dEx Thanks for your patience—ended up being more here than I expected. I think this is basically ready except a few small typos/tweaks. If you've got time, it would be great if you took this branch for a test drive and took a look at the code changes. |
c02cc47
to
1e09e0a
Compare
Planning to rebase on top of #461 when that is in so that tests are reliable. |
1e09e0a
to
12f7388
Compare
@jayqi Should be ready for the release. Scope/maintenance burden is a little larger, but I think this is a large standing issue with a fair amount of interest so it is worth it to get in. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, it feels a little messy but I think it's reasonable.
Truer words were never spoken. |
This reverts commit bb36a52.
Add initial ADLS gen2 support:
data_lake_service_client
AzureBlobClient
use thedata_lake_service_client
API. This does not use the ADLS API everywhere possible since ADLS Gen2 works with the normal blob API in many places. Do this since it is common to enable hierarchical namespaces when creating a blob storage account, not realizing that it needs ADLS APIs for some scenarios.This also incorporates the fixes in:
_list_dir
#447Closes #161