Default to sig v4 #82
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sleg-aws
reviewed
Jan 21, 2021
| @@ -42,7 +42,9 @@ module SES | |||
| DEFAULT_HOST = 'email.us-east-1.amazonaws.com' | |||
|
|
|||
| DEFAULT_MESSAGE_ID_DOMAIN = 'email.amazonses.com' | |||
|
|
|||
|
|
|||
| DEFAULT_SIGNATURE_VERSION = 4 | |||
There was a problem hiding this comment.
Dev from AWS SES here. Thanks for this initiative. Sigv4 is not just going to be the default, it's going to be the only signing method supported in the near future, so I don't think backward compatibility applies here, only Sigv4 can remain
sleg-aws
approved these changes
Mar 23, 2021
|
@sleg-aws by when can you merge this PR? |
|
@girisha-g I don't own this repo. This is not a AWS-owned repository. You may contact people with write-access to this repo. |
|
@drewblas can you merge and release this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signature Version 2 will be retired on March 27th, 2021. Let's default to v4, so users wont have to explicitly force this version.