Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better bots #1701

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Better bots #1701

wants to merge 5 commits into from

Conversation

mixmix
Copy link
Member

@mixmix mixmix commented Apr 19, 2023

This PR creates bots that do more than pick randomly:

  • for the first 6 picks, it chooses the rarest card in the pack
    • if there are ties it choose randomly among them
  • after 6 picks, it choose it's 2 colors - these are just the 2 most common colors from pick so far
  • for subsequent picks the bots chooses the rarest cards in it's colors
    • if it can't, then it choose the rarest card (or was it a random card)

This is a super simple improvement. Lots of space for improvement AND play-testing suggests it's already a massive improvement - you don't get bots wheeling bombs and random players getting way overpowered... but you do get bombs wheeling in packs 2-3 more because the bots aren't in those cards colours.

you can try it out here : http://magic.protozoa.nz:1337

@mixmix mixmix requested review from ZeldaZach and tooomm April 19, 2023 11:06
@ZeldaZach
Copy link
Member

I'm open to merging as-is and seeing how things change over time

@ZeldaZach
Copy link
Member

We should be passing our tests first thought @mixmix

@mixmix
Copy link
Member Author

mixmix commented Apr 19, 2023

I have a bad feeling there is an intermitently failing test.
Oh yeah its a pack making function - not all packs are unique cards for some sets. I started looking into it, but it was a bit opaque

@mixmix
Copy link
Member Author

mixmix commented Apr 25, 2023

Ok my bad there were some linting things with semi-colons 🤮
But we still have an intermittently failing test on Pool creation for some sets. It's in master

@mixmix
Copy link
Member Author

mixmix commented Apr 25, 2023

arg... no idea why this is failing...

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants