Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing HighContrast theme in Fluent #10094

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

dipeshmsft
Copy link
Member

@dipeshmsft dipeshmsft commented Nov 19, 2024

Fixes # #10043

Main PR

Description

While fixing TemplateBinding for different controls, some resource keys in HC.xaml got duplicated, which when loaded causes the above issue.

Customer Impact

Developers will be able to use Fluent in HighContrast mode.

Regression

Yes, as compared to .NET 9 Preview 4 release.

Testing

Ad-hoc testing.

Risk

Minimal.

Microsoft Reviewers: Open in CodeFlow

@dipeshmsft dipeshmsft requested review from a team as code owners November 19, 2024 07:53
@dotnet-policy-service dotnet-policy-service bot added the PR metadata: Label to tag PRs, to facilitate with triage label Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR metadata: Label to tag PRs, to facilitate with triage Win 11 Theming
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

1 participant