Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Hashtable/ArrayList in AccessKeyManager and remove locks #10000

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

Replace Hashtable/ArrayList in AccessKeyManager and remove locks #10000

Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
d9ef41d
Swap _keyToElements from Hashtable to Dictionary<string, ArrayList>
h3xds1nz Oct 16, 2024
a00140d
Replace ArrayList inside Dictionary with List<WeakReference>
h3xds1nz Oct 16, 2024
7e12246
Convert WeakReference as generic WeakReference<IInputElement>
h3xds1nz Oct 16, 2024
b118221
Mark functions that could be static
h3xds1nz Oct 16, 2024
ea8fdcd
Mark GetAccessKeyCharacter static as well
h3xds1nz Oct 16, 2024
3de643d
Remove locks for _keyToElements as instances of AccessKeyManager are …
h3xds1nz Oct 16, 2024
72012c2
Mark rest of the methods static and work off the thread variable
h3xds1nz Oct 25, 2024
1201064
Simplify OnText/OnKeyDown
h3xds1nz Oct 25, 2024
f515939
Use pattern matching and remove CriticalGetActiveSource (identical me…
h3xds1nz Oct 25, 2024
936119a
Rewrite AccessKeyInformation as immutable readonly struct
h3xds1nz Oct 25, 2024
faf134d
Remove redundant usings
h3xds1nz Oct 25, 2024
81a845b
Mark PostProcessInput as static too
h3xds1nz Oct 25, 2024
edc2692
Mark fields in events readonly, one last pattern-match
h3xds1nz Oct 25, 2024
330dfc4
Simplify IsTargetable
h3xds1nz Oct 25, 2024
32d89ed
Strongly type in PurgeDead
h3xds1nz Oct 25, 2024
4930266
Remove a null check that we don't need
h3xds1nz Oct 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading