Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[main] Update dependencies from dotnet/runtime #43061

Closed

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Aug 28, 2024

Coherency update: Failed to perform coherency update for one or more dependencies. Please review the GitHub checks or run darc update-dependencies --coherency-only locally against darc-main-52b92e84-decf-478b-8f42-cd2ec2440388 for more information.

Coherency Updates

The following updates ensure that dependencies with a CoherentParentDependency
attribute were produced in a build used as input to the parent dependency's build.
See Dependency Description Format

  • Coherency Updates:
    • Microsoft.NET.Workload.Emscripten.Current.Manifest-10.0.100.Transport: from 10.0.0-alpha.1.24468.9 to 10.0.0-alpha.1.24474.1 (parent: Microsoft.NETCore.App.Runtime.win-x64)
    • Microsoft.SourceBuild.Intermediate.emsdk: from 10.0.0-alpha.1.24468.9 to 10.0.0-alpha.1.24474.1 (parent: Microsoft.NETCore.App.Runtime.win-x64)

From https://github.com/dotnet/runtime

  • Subscription: cedddd63-79f5-4e7e-6d46-08dc434c4948
  • Build: 20241004.10
  • Date Produced: October 5, 2024 9:29:21 AM UTC
  • Commit: 0372b5080a4aec8d73d6861ad4b993d9d0fe3a11
  • Branch: refs/heads/main

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-CodeFlow untriaged Request triage from a team member labels Aug 28, 2024
Copy link
Contributor Author

Notification for subscribed users from https://github.com/dotnet/runtime:

@dotnet/dnr-codeflow

Action requested: Please take a look at this failing automated dependency-flow pull request's checks; failures may be related to changes which originated in your repo.

  • This pull request contains changes from your source repo (https://github.com/dotnet/runtime) and seems to have failed checks in this PR. Please take a peek at the failures and comment if they seem relevant to your changes.
  • If you're being tagged in this comment it is due to an entry in the related Maestro Subscription of the Build Asset Registry. If you feel this entry has added your GitHub login or your GitHub team in error, please update the subscription to reflect this.
  • For more details, please read the Arcade Darc documentation

@dsplaisted
Copy link
Member

Looks like the .NET 10 runtime isn't being installed correctly:

2024-08-30T13:02:49.1866436Z You must install or update .NET to run this application.
2024-08-30T13:02:49.1867930Z
2024-08-30T13:02:49.1868892Z App: D:\a_work\1\s\artifacts\bin\redist\Release\dotnet\sdk\10.0.100-ci\dotnet.dll
2024-08-30T13:02:49.1870872Z Architecture: x64
2024-08-30T13:02:49.1872600Z Framework: 'Microsoft.NETCore.App', version '10.0.0-alpha.1.24429.17' (x64)
2024-08-30T13:02:49.1872993Z .NET location: D:\a_work\1\s\artifacts\bin\redist\Release\dotnet
2024-08-30T13:02:49.1874235Z
2024-08-30T13:02:49.1876558Z The following frameworks were found:
2024-08-30T13:02:49.1879445Z 6.0.0 at [D:\a_work\1\s\artifacts\bin\redist\Release\dotnet\shared\Microsoft.NETCore.App]
2024-08-30T13:02:49.1879802Z 7.0.0 at [D:\a_work\1\s\artifacts\bin\redist\Release\dotnet\shared\Microsoft.NETCore.App]
2024-08-30T13:02:49.1881518Z 8.0.0 at [D:\a_work\1\s\artifacts\bin\redist\Release\dotnet\shared\Microsoft.NETCore.App]
2024-08-30T13:02:49.1882692Z 9.0.0-preview.7.24405.7 at [D:\a_work\1\s\artifacts\bin\redist\Release\dotnet\shared\Microsoft.NETCore.App]
2024-08-30T13:02:49.1884617Z 9.0.0-rc.1.24412.13 at [D:\a_work\1\s\artifacts\bin\redist\Release\dotnet\shared\Microsoft.NETCore.App]
2024-08-30T13:02:49.1885796Z 9.0.0-rc.1.24414.5 at [D:\a_work\1\s\artifacts\bin\redist\Release\dotnet\shared\Microsoft.NETCore.App]

@dsplaisted
Copy link
Member

Tracking issue for net10 updates: #42920

@jeffschwMSFT
Copy link
Member

Tracking issue for net10 updates: #42920

@dsplaisted what is the priority/timeline for doing the outstanding work to get main to .NET 10?

@dsplaisted
Copy link
Member

@dsplaisted what is the priority/timeline for doing the outstanding work to get main to .NET 10?

I'll defer to @marcpopMSFT on that.

@marcpopMSFT
Copy link
Member

@jeffschwMSFT I raised this in tactics on Tuesday. @agocke said he would look into the blockers but I haven't seen an update. I've been struggling to get traction from runtime to help investigate when pinging in GH or in Teams. The PR is this one that Jason separated out so that runtime and aspnet could flow together and we could control updates to the PR: #43070

@agocke
Copy link
Member

agocke commented Sep 12, 2024

I looked into it on Tuesday but the failures are wasm, which will take me a bit to ramp up on. I’ve been distracted by .NET 9 infra issues, so I may need a while longer to fix this.

@lewing
Copy link
Member

lewing commented Sep 20, 2024

The runtime pr that should resolve much of this is dotnet/runtime#106599 which is currently blocked on BDN

…0922.5

Microsoft.Bcl.AsyncInterfaces , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.Logging , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging.Console , Microsoft.NET.HostModel , Microsoft.NET.ILLink.Tasks , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.Platforms , Microsoft.Win32.SystemEvents , System.CodeDom , System.Composition.AttributedModel , System.Composition.Convention , System.Composition.Hosting , System.Composition.Runtime , System.Composition.TypedParts , System.Configuration.ConfigurationManager , System.Formats.Asn1 , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.Pkcs , System.Security.Cryptography.ProtectedData , System.Security.Cryptography.Xml , System.Security.Permissions , System.ServiceProcess.ServiceController , System.Text.Encoding.CodePages , System.Text.Json , System.Windows.Extensions , Microsoft.SourceBuild.Intermediate.runtime.linux-x64
 From Version 10.0.0-alpha.1.24471.6 -> To Version 10.0.0-alpha.1.24472.5
…0924.1

Microsoft.Bcl.AsyncInterfaces , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.Logging , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging.Console , Microsoft.NET.HostModel , Microsoft.NET.ILLink.Tasks , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.Platforms , Microsoft.Win32.SystemEvents , System.CodeDom , System.Composition.AttributedModel , System.Composition.Convention , System.Composition.Hosting , System.Composition.Runtime , System.Composition.TypedParts , System.Configuration.ConfigurationManager , System.Formats.Asn1 , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.Pkcs , System.Security.Cryptography.ProtectedData , System.Security.Cryptography.Xml , System.Security.Permissions , System.ServiceProcess.ServiceController , System.Text.Encoding.CodePages , System.Text.Json , System.Windows.Extensions , Microsoft.SourceBuild.Intermediate.runtime.linux-x64
 From Version 10.0.0-alpha.1.24472.5 -> To Version 10.0.0-alpha.1.24474.1
@jeffschwMSFT
Copy link
Member

@lewing @agocke @steveisok who can assist with the version conflicts in this pr?

@marcpopMSFT
Copy link
Member

Reminder that the focus in main should be on this PR: #43070

We need to get unblocked and that PR is still pending multiple other investigations and flows.

@lewing
Copy link
Member

lewing commented Sep 25, 2024

I just merged dotnet/runtime#106599 I will update #43070 once there is an official build

…0925.8

Microsoft.Bcl.AsyncInterfaces , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.Logging , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging.Console , Microsoft.NET.HostModel , Microsoft.NET.ILLink.Tasks , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.Platforms , Microsoft.Win32.SystemEvents , System.CodeDom , System.Composition.AttributedModel , System.Composition.Convention , System.Composition.Hosting , System.Composition.Runtime , System.Composition.TypedParts , System.Configuration.ConfigurationManager , System.Formats.Asn1 , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.Pkcs , System.Security.Cryptography.ProtectedData , System.Security.Cryptography.Xml , System.Security.Permissions , System.ServiceProcess.ServiceController , System.Text.Encoding.CodePages , System.Text.Json , System.Windows.Extensions , Microsoft.SourceBuild.Intermediate.runtime.linux-x64
 From Version 10.0.0-alpha.1.24474.1 -> To Version 10.0.0-alpha.1.24475.8
…0926.10

Microsoft.Bcl.AsyncInterfaces , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.Logging , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging.Console , Microsoft.NET.HostModel , Microsoft.NET.ILLink.Tasks , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.Platforms , Microsoft.Win32.SystemEvents , System.CodeDom , System.Composition.AttributedModel , System.Composition.Convention , System.Composition.Hosting , System.Composition.Runtime , System.Composition.TypedParts , System.Configuration.ConfigurationManager , System.Formats.Asn1 , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.Pkcs , System.Security.Cryptography.ProtectedData , System.Security.Cryptography.Xml , System.Security.Permissions , System.ServiceProcess.ServiceController , System.Text.Encoding.CodePages , System.Text.Json , System.Windows.Extensions , Microsoft.SourceBuild.Intermediate.runtime.linux-x64
 From Version 10.0.0-alpha.1.24475.8 -> To Version 10.0.0-alpha.1.24476.10
…0927.10

Microsoft.Bcl.AsyncInterfaces , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.Logging , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging.Console , Microsoft.NET.HostModel , Microsoft.NET.ILLink.Tasks , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.Platforms , Microsoft.Win32.SystemEvents , System.CodeDom , System.Composition.AttributedModel , System.Composition.Convention , System.Composition.Hosting , System.Composition.Runtime , System.Composition.TypedParts , System.Configuration.ConfigurationManager , System.Formats.Asn1 , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.Pkcs , System.Security.Cryptography.ProtectedData , System.Security.Cryptography.Xml , System.Security.Permissions , System.ServiceProcess.ServiceController , System.Text.Encoding.CodePages , System.Text.Json , System.Windows.Extensions , Microsoft.SourceBuild.Intermediate.runtime.linux-x64
 From Version 10.0.0-alpha.1.24476.10 -> To Version 10.0.0-alpha.1.24477.10
…0928.1

Microsoft.Bcl.AsyncInterfaces , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.Logging , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging.Console , Microsoft.NET.HostModel , Microsoft.NET.ILLink.Tasks , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.Platforms , Microsoft.Win32.SystemEvents , System.CodeDom , System.Composition.AttributedModel , System.Composition.Convention , System.Composition.Hosting , System.Composition.Runtime , System.Composition.TypedParts , System.Configuration.ConfigurationManager , System.Formats.Asn1 , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.Pkcs , System.Security.Cryptography.ProtectedData , System.Security.Cryptography.Xml , System.Security.Permissions , System.ServiceProcess.ServiceController , System.Text.Encoding.CodePages , System.Text.Json , System.Windows.Extensions , Microsoft.SourceBuild.Intermediate.runtime.linux-x64
 From Version 10.0.0-alpha.1.24477.10 -> To Version 10.0.0-alpha.1.24478.1
…0929.4

Microsoft.Bcl.AsyncInterfaces , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.Logging , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging.Console , Microsoft.NET.HostModel , Microsoft.NET.ILLink.Tasks , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.Platforms , Microsoft.Win32.SystemEvents , System.CodeDom , System.Composition.AttributedModel , System.Composition.Convention , System.Composition.Hosting , System.Composition.Runtime , System.Composition.TypedParts , System.Configuration.ConfigurationManager , System.Formats.Asn1 , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.Pkcs , System.Security.Cryptography.ProtectedData , System.Security.Cryptography.Xml , System.Security.Permissions , System.ServiceProcess.ServiceController , System.Text.Encoding.CodePages , System.Text.Json , System.Windows.Extensions , Microsoft.SourceBuild.Intermediate.runtime.linux-x64
 From Version 10.0.0-alpha.1.24478.1 -> To Version 10.0.0-alpha.1.24479.4
…0930.6

Microsoft.Bcl.AsyncInterfaces , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.Logging , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging.Console , Microsoft.NET.HostModel , Microsoft.NET.ILLink.Tasks , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.Platforms , Microsoft.Win32.SystemEvents , System.CodeDom , System.Composition.AttributedModel , System.Composition.Convention , System.Composition.Hosting , System.Composition.Runtime , System.Composition.TypedParts , System.Configuration.ConfigurationManager , System.Formats.Asn1 , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.Pkcs , System.Security.Cryptography.ProtectedData , System.Security.Cryptography.Xml , System.Security.Permissions , System.ServiceProcess.ServiceController , System.Text.Encoding.CodePages , System.Text.Json , System.Windows.Extensions , Microsoft.SourceBuild.Intermediate.runtime.linux-x64
 From Version 10.0.0-alpha.1.24479.4 -> To Version 10.0.0-alpha.1.24480.6
…1001.8

Microsoft.Bcl.AsyncInterfaces , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.Logging , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging.Console , Microsoft.NET.HostModel , Microsoft.NET.ILLink.Tasks , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.Platforms , Microsoft.Win32.SystemEvents , System.CodeDom , System.Composition.AttributedModel , System.Composition.Convention , System.Composition.Hosting , System.Composition.Runtime , System.Composition.TypedParts , System.Configuration.ConfigurationManager , System.Formats.Asn1 , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.Pkcs , System.Security.Cryptography.ProtectedData , System.Security.Cryptography.Xml , System.Security.Permissions , System.ServiceProcess.ServiceController , System.Text.Encoding.CodePages , System.Text.Json , System.Windows.Extensions , Microsoft.SourceBuild.Intermediate.runtime.linux-x64
 From Version 10.0.0-alpha.1.24480.6 -> To Version 10.0.0-alpha.1.24501.8
…1003.1

Microsoft.Bcl.AsyncInterfaces , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.Logging , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging.Console , Microsoft.NET.HostModel , Microsoft.NET.ILLink.Tasks , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.Platforms , Microsoft.Win32.SystemEvents , System.CodeDom , System.Composition.AttributedModel , System.Composition.Convention , System.Composition.Hosting , System.Composition.Runtime , System.Composition.TypedParts , System.Configuration.ConfigurationManager , System.Formats.Asn1 , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.Pkcs , System.Security.Cryptography.ProtectedData , System.Security.Cryptography.Xml , System.Security.Permissions , System.ServiceProcess.ServiceController , System.Text.Encoding.CodePages , System.Text.Json , System.Windows.Extensions , Microsoft.SourceBuild.Intermediate.runtime.linux-x64
 From Version 10.0.0-alpha.1.24501.8 -> To Version 10.0.0-alpha.1.24503.1
@nagilson
Copy link
Member

nagilson commented Oct 7, 2024

@lewing VSRedistCommonNetCoreSharedFrameworkx64100PackageVersion appears to not be defined correctly now. Are you familiar with what we need to do to resolve this?

@kasperk81
Copy link
Contributor

need to make VSRedistCommonNetCoreSharedFrameworkx6490PackageVersion to VSRedistCommonNetCoreSharedFrameworkx64100PackageVersion changes similar to https://github.com/dotnet/sdk/pull/43070/files ?

eng/Versions.props Outdated Show resolved Hide resolved
nagilson and others added 4 commits October 7, 2024 13:37
Co-authored-by: kasperk81 <83082615+kasperk81@users.noreply.github.com>
Co-authored-by: kasperk81 <83082615+kasperk81@users.noreply.github.com>
Co-authored-by: kasperk81 <83082615+kasperk81@users.noreply.github.com>
@kasperk81
Copy link
Contributor

next one is vstest related

Writing file: /Users/runner/work/1/s/artifacts/bin/redist/Release/net9.0/vstest.console.runtimeconfig.json
  9.0.100-rc.1.24452.12
    Determining projects to restore...
    Restored /Users/runner/work/1/s/template_feed/Microsoft.DotNet.Common.ProjectTemplates.9.0/Microsoft.DotNet.Common.ProjectTemplates.9.0.csproj (in 437 ms).
    Successfully created package '/Users/runner/work/1/s/artifacts/bin/redist/Release/dotnet/templates/9.0.0-rc.1.24452.1/Microsoft.DotNet.Common.ProjectTemplates.9.0.10.0.100-dev.nupkg'.
    Successfully created package '/Users/runner/work/1/s/artifacts/bin/redist/Release/dotnet/templates/9.0.0-rc.1.24452.1/Microsoft.DotNet.Common.ProjectTemplates.9.0.10.0.100-dev.symbols.nupkg'.
    Determining projects to restore...
    Restored /Users/runner/work/1/s/template_feed/Microsoft.DotNet.Common.ItemTemplates/Microsoft.DotNet.Common.ItemTemplates.csproj (in 412 ms).
    Successfully created package '/Users/runner/work/1/s/artifacts/bin/redist/Release/dotnet/templates/9.0.0-rc.1.24452.1/Microsoft.DotNet.Common.ItemTemplates.10.0.100-dev.nupkg'.
    Successfully created package '/Users/runner/work/1/s/artifacts/bin/redist/Release/dotnet/templates/9.0.0-rc.1.24452.1/Microsoft.DotNet.Common.ItemTemplates.10.0.100-dev.symbols.nupkg'.
  You must install or update .NET to run this application.
  
  App: /Users/runner/work/1/s/artifacts/bin/redist/Release/dotnet/sdk/10.0.100-ci/dotnet.dll
  Architecture: x64
  Framework: 'Microsoft.NETCore.App', version '10.0.0-alpha.1.24504.10' (x64)
  .NET location: /Users/runner/work/1/s/artifacts/bin/redist/Release/dotnet/
  
  The following frameworks were found:
    6.0.0 at [/Users/runner/work/1/s/artifacts/bin/redist/Release/dotnet/shared/Microsoft.NETCore.App]
    7.0.0 at [/Users/runner/work/1/s/artifacts/bin/redist/Release/dotnet/shared/Microsoft.NETCore.App]
    8.0.0 at [/Users/runner/work/1/s/artifacts/bin/redist/Release/dotnet/shared/Microsoft.NETCore.App]
    9.0.0-rc.1.24431.7 at [/Users/runner/work/1/s/artifacts/bin/redist/Release/dotnet/shared/Microsoft.NETCore.App]
    10.0.0-alpha.1.24476.2 at [/Users/runner/work/1/s/artifacts/bin/redist/Release/dotnet/shared/Microsoft.NETCore.App]
    10.0.0-alpha.1.24480.6 at [/Users/runner/work/1/s/artifacts/bin/redist/Release/dotnet/shared/Microsoft.NETCore.App]

…1004.10

System.IO.Hashing , VS.Redist.Common.NetCore.SharedFramework.x64.10.0 , VS.Redist.Common.NetCore.TargetingPack.x64.10.0
 From Version 10.0.0-alpha.1.24476.2 -> To Version 10.0.0-alpha.1.24504.10

Dependency coherency updates

Microsoft.NET.Workload.Emscripten.Current.Manifest-10.0.100.Transport,Microsoft.SourceBuild.Intermediate.emsdk
 From Version 10.0.0-alpha.1.24468.9 -> To Version 10.0.0-alpha.1.24474.1 (parent: Microsoft.NETCore.App.Runtime.win-x64
@kasperk81
Copy link
Contributor

Coherency update: Failed to perform coherency update for one or more dependencies. Please review the GitHub checks or run darc update-dependencies --coherency-only locally against darc-main-52b92e84-decf-478b-8f42-cd2ec2440388 for more information.

would it help to close this and let the bot open a fresh one for a clean slate?

@nagilson
Copy link
Member

nagilson commented Oct 7, 2024

If this does not pass then I probably will do that, good suggestion

<!-- Temporarily pinned to a net9 supporting version until the SDK can target net10.
See https://github.com/dotnet/sdk/issues/42920. -->
<Dependency Name="System.Windows.Extensions" Version="9.0.0-rc.1.24431.7" Pinned="True">
<Dependency Name="System.Windows.Extensions" Version="10.0.0-alpha.1.24504.10">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<Dependency Name="System.Windows.Extensions" Version="10.0.0-alpha.1.24504.10">
<!-- Temporarily pinned to a net9 supporting version until the SDK can target net10.
See [https://github.com/dotnet/sdk/issues/42920.](https://github.com/dotnet/sdk/issues/42920.?q=sort%3Aupdated-desc+is%3Aissue+is%3Aopen) -->
<Dependency Name="System.Windows.Extensions" Version="9.0.0-rc.1.24431.7" Pinned="True">

needs to stay pinned

<Uri>https://github.com/dotnet/runtime</Uri>
<Sha>c4d7f7c6f2e2f34f07e64c6caa3bf9b2ce915cc1</Sha>
<Sha>0372b5080a4aec8d73d6861ad4b993d9d0fe3a11</Sha>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<Sha>0372b5080a4aec8d73d6861ad4b993d9d0fe3a11</Sha>
<Sha>c4d7f7c6f2e2f34f07e64c6caa3bf9b2ce915cc1</Sha>

<SystemSecurityPermissionsPackageVersion>10.0.0-alpha.1.24504.10</SystemSecurityPermissionsPackageVersion>
<SystemTextEncodingCodePagesPackageVersion>10.0.0-alpha.1.24504.10</SystemTextEncodingCodePagesPackageVersion>
<SystemTextJsonPackageVersion>10.0.0-alpha.1.24504.10</SystemTextJsonPackageVersion>
<SystemWindowsExtensionsPackageVersion>10.0.0-alpha.1.24504.10</SystemWindowsExtensionsPackageVersion>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<SystemWindowsExtensionsPackageVersion>10.0.0-alpha.1.24504.10</SystemWindowsExtensionsPackageVersion>
<SystemWindowsExtensionsPackageVersion>9.0.0-rc.1.24431.7</SystemWindowsExtensionsPackageVersion>

<!-- Temporarily pinned to a net9 supporting version until the SDK can target net10.
See https://github.com/dotnet/sdk/issues/42920. -->
<Dependency Name="System.Reflection.MetadataLoadContext" Version="9.0.0-rc.1.24431.7" Pinned="True">
<Dependency Name="System.Reflection.MetadataLoadContext" Version="10.0.0-alpha.1.24504.10">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<Dependency Name="System.Reflection.MetadataLoadContext" Version="10.0.0-alpha.1.24504.10">
<!-- Temporarily pinned to a net9 supporting version until the SDK can target net10.
See [https://github.com/dotnet/sdk/issues/42920.](https://github.com/dotnet/sdk/issues/42920.?q=sort%3Aupdated-desc+is%3Aissue+is%3Aopen) -->
<Dependency Name="System.Reflection.MetadataLoadContext" Version="9.0.0-rc.1.24431.7" Pinned="True">

<Uri>https://github.com/dotnet/runtime</Uri>
<Sha>c4d7f7c6f2e2f34f07e64c6caa3bf9b2ce915cc1</Sha>
<Sha>0372b5080a4aec8d73d6861ad4b993d9d0fe3a11</Sha>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<Sha>0372b5080a4aec8d73d6861ad4b993d9d0fe3a11</Sha>
<Sha>c4d7f7c6f2e2f34f07e64c6caa3bf9b2ce915cc1</Sha>

<SystemCompositionRuntimePackageVersion>10.0.0-alpha.1.24504.10</SystemCompositionRuntimePackageVersion>
<SystemCompositionTypedPartsPackageVersion>10.0.0-alpha.1.24504.10</SystemCompositionTypedPartsPackageVersion>
<SystemConfigurationConfigurationManagerPackageVersion>10.0.0-alpha.1.24504.10</SystemConfigurationConfigurationManagerPackageVersion>
<SystemReflectionMetadataLoadContextVersion>10.0.0-alpha.1.24504.10</SystemReflectionMetadataLoadContextVersion>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<SystemReflectionMetadataLoadContextVersion>10.0.0-alpha.1.24504.10</SystemReflectionMetadataLoadContextVersion>
<SystemReflectionMetadataLoadContextVersion>9.0.0-rc.1.24431.7</SystemReflectionMetadataLoadContextVersion>

@lewing
Copy link
Member

lewing commented Oct 7, 2024

#43945

@nagilson
Copy link
Member

nagilson commented Oct 7, 2024

I think we're just going to take that one: #43945
Thanks @lewing and sorry for the lost commits there.

@nagilson nagilson closed this Oct 7, 2024
auto-merge was automatically disabled October 7, 2024 22:56

Pull request was closed

@dotnet-maestro dotnet-maestro bot deleted the darc-main-52b92e84-decf-478b-8f42-cd2ec2440388 branch October 7, 2024 22:58
@lewing
Copy link
Member

lewing commented Oct 7, 2024

I think we're just going to take that one: #43945 Thanks @lewing and sorry for the lost commits there.

No worries, just simpler to start fresh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-CodeFlow untriaged Request triage from a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants