Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change assertion in IPGlobalProperties_DomainName_ReturnsEmptyStringWhenNotSet #110070

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Change assertion in IPGlobalProperties_DomainName_ReturnsEmptyStringWhenNotSet #110070

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b4fc249
change assertion in IPGlobalProperties_DomainName_ReturnsEmptyStringW…
antonfirsov Nov 22, 2024
815fe4c
[ActiveIssue]
antonfirsov Nov 22, 2024
a12adf3
filter only to IsAndroid
antonfirsov Nov 22, 2024
05f61eb
Merge branch 'main' into IPGlobalProperties_DomainName_ReturnsEmptySt…
antonfirsov Nov 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/libraries/System.Net.NetworkInformation/tests/FunctionalTests/IPGlobalPropertiesTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,10 @@ public async Task GetUnicastAddresses_NotEmpty()
public void IPGlobalProperties_DomainName_ReturnsEmptyStringWhenNotSet()
{
IPGlobalProperties gp = IPGlobalProperties.GetIPGlobalProperties();
Assert.Equal(string.Empty, gp.DomainName);

// [ActiveIssue("https://github.com/dotnet/runtime/issues/109280")]
string expectedDomainName = PlatformDetection.IsAndroid ? "localdomain" : string.Empty;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if we re4ally need the comment but I'm OK keeping it.

Assert.Equal(expectedDomainName, gp.DomainName);
}
}
}
Loading