Fix parameters not showing up in 'nameof' on a method #76017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
|
@genlu ptal |
ToddGrun
reviewed
Nov 25, 2024
| ? null | ||
| : semanticModel.GetSymbolInfo(enclosingMethodOrLambdaNode).GetAnySymbol() ?? semanticModel.GetDeclaredSymbol(enclosingMethodOrLambdaNode); | ||
| if (enclosingMethodOrLambda is IMethodSymbol method) | ||
| symbols = [.. symbols.Concat(method.Parameters)]; |
There was a problem hiding this comment.
likely yes. will fixup.
There was a problem hiding this comment.
no. .Concat returns an IEnumerqable here.
There was a problem hiding this comment.
That's confusing. symbols is an IA, method.Parameters is an IA, isn't this invoking the IA overload for Concat?
There was a problem hiding this comment.
no, it's not. i get an error when i try :)
There was a problem hiding this comment.
oh, I see. One is IA, the other is IA. It needs to be:
symbols.Concat(method.Parameters.Cast());
There was a problem hiding this comment.
oh, just a sec, I thought that cast call just cast the array, not enumerate
There was a problem hiding this comment.
Duh, it's CastArray, not Cast
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #60812