[iOS] [Android] Fix for Shell custom FlyoutIcon display problem #26016
+109
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @Tamilarasan-Paranthaman! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
jsuarezruiz
added
platform/iOS 🍎
area-controls-shell
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
jsuarezruiz
requested changes
Nov 26, 2024
| @@ -336,7 +336,7 @@ void UpdateLeftToolbarItems() | |||
| if (image != null) | |||
| { | |||
| icon = result?.Value; | |||
| icon = ResizeImage(result?.Value, new CGSize(23f, 23f)); | |||
There was a problem hiding this comment.
Is iOS the only one that doesn't resize?
Is this size correct under all the screen options? (@2x etc) https://developer.apple.com/design/human-interface-guidelines/toolbars
| @@ -0,0 +1,27 @@ | |||
| #if !WINDOWS | |||
| // In Windows, the foreground color is not applied to the custom icon, | |||
| // so as of now, the test is not applicable for Windows. | |||
There was a problem hiding this comment.
Windows is the only one having a different behavior, right?
Could you open a new issue and include the link in the comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue 1: Foreground color of the custom flyout icon is not applied.
Root Cause of the issue
Description of Change
Issue 2: The flyout icon is aligned to the center instead of the left, causing the title to extend beyond the view.
Root Cause of the issue
Description of Change
Reference for icon size: https://github.com/dotnet/maui/blob/main/src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/ShellPageRendererTracker.cs#L450
Issues Fixed
Fixes #25920
Tested the behaviour in the following platforms
Screenshot
iOS
Android"