Fixed Net 8: Page and control Unloaded events firing on iOS when navigating to another page #25852
+119
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NirmalKumarYuvaraj
changed the title
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
jsuarezruiz
requested changes
Nov 14, 2024
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/rebase |
github-actions
bot
force-pushed
the
fix-21916
branch
from
07004e9
to
3895e96
Compare
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
jsuarezruiz
reviewed
Nov 21, 2024
| @@ -0,0 +1,28 @@ | |||
| #if !ANDROID && !MACCATALYST | |||
There was a problem hiding this comment.
Why avoid Android? Could be nice to test the same behavior in all the platforms.
There was a problem hiding this comment.
On the Android platform, the Unloaded event of the current page is not triggered when navigating to the next page. As a result, the UI test case for Android has been skipped. Let me know if you have any further concerns.
Android issue link : #26050
There was a problem hiding this comment.
Could you include a comment and the link to the issue?
There was a problem hiding this comment.
@jsuarezruiz , here is the link to the issue - #26050
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Details:
On the iOS platform, the Loaded and Unloaded events of the current page are triggered twice when navigating to another page.
Root Cause:
The MovedToWindow method in the MauiView class is called twice when page navigation occurs with animation enabled. This behavior causes the _movedToWindow event to be repeatedly wired and unwired, which sequentially triggers the Loaded and Unloaded events.
Description of Change:
To resolve the issue, I moved the UnloadedCheck and OnLoadedCheck methods to the UI thread. This change ensures that calls are queued on the UI thread, allowing the Loaded and Unloaded events to trigger correctly once the UIView is attached to a window. Additionally, I removed redundant code for wiring the Loaded and Unloaded events, as the MovedToWindow method will handle these triggers for all MauiView instances upon attachment to and detachment from the window, with the events firing directly from _movedToWindow
Tested the behaviour in the following platforms.
Reference
https://stackoverflow.com/questions/34484518/willmovetowindow-is-called-twice
Issues Fixed
Fixes #21916
Screenshots
Before Issue Fix
before.2.mov
After Issue Fix
after.2.mov