-
Notifications
You must be signed in to change notification settings - Fork 788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #17903 #18025
base: main
Are you sure you want to change the base?
Fix #17903 #18025
Conversation
❗ Release notes requiredCaution No release notes found for the changed paths (see table below). Please make sure to add an entry with an informative description of the change as well as link to this pull request, issue and language suggestion if applicable. Release notes for this repository are based on Keep A Changelog format. The following format is recommended for this repository:
If you believe that release notes are not necessary for this PR, please add NO_RELEASE_NOTES label to the pull request. You can open this PR in browser to add release notes: open in github.dev
|
/run fantomas |
Co-authored-by: vzarytovskii <1260985+vzarytovskii@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A test would be nice.
Co-authored-by: Petr Pokorny <petr@innit.cz>
Fixes #17903. Test is missing, checking the waters.
The idea of the fix is pretty dumb. The
copyOfStruct
address is leaking outside the scope which trips the locals reuse algorithm. After looking more into it, and chatting with Don, I decided to markcopyOfStruct
as no-reuse, but keeping it in cgbuf cache.