Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #17903 #18025

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Fix #17903 #18025

wants to merge 7 commits into from

Conversation

vzarytovskii
Copy link
Member

Fixes #17903. Test is missing, checking the waters.

The idea of the fix is pretty dumb. The copyOfStruct address is leaking outside the scope which trips the locals reuse algorithm. After looking more into it, and chatting with Don, I decided to mark copyOfStruct as no-reuse, but keeping it in cgbuf cache.

@vzarytovskii vzarytovskii requested a review from a team as a code owner November 18, 2024 18:49
Copy link
Contributor

❗ Release notes required

@vzarytovskii,

Caution

No release notes found for the changed paths (see table below).

Please make sure to add an entry with an informative description of the change as well as link to this pull request, issue and language suggestion if applicable. Release notes for this repository are based on Keep A Changelog format.

The following format is recommended for this repository:

* <Informative description>. ([PR #XXXXX](https://github.com/dotnet/fsharp/pull/XXXXX))

See examples in the files, listed in the table below or in th full documentation at https://fsharp.github.io/fsharp-compiler-docs/release-notes/About.html.

If you believe that release notes are not necessary for this PR, please add NO_RELEASE_NOTES label to the pull request.

You can open this PR in browser to add release notes: open in github.dev

Change path Release notes path Description
src/Compiler docs/release-notes/.FSharp.Compiler.Service/9.0.200.md No release notes found or release notes format is not correct

@vzarytovskii
Copy link
Member Author

/run fantomas

  Co-authored-by: vzarytovskii <1260985+vzarytovskii@users.noreply.github.com>
Copy link
Contributor

Copy link
Contributor

@0101 0101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A test would be nice.

src/Compiler/CodeGen/IlxGen.fs Show resolved Hide resolved
src/Compiler/CodeGen/IlxGen.fs Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: New
Development

Successfully merging this pull request may close these issues.

Inline functions in a referenced project optimized incorrectly
2 participants