Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use NetMinimum and NetFrameworkMinimum floating TFMs #2335

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

ViktorHofer
Copy link
Member

@ViktorHofer ViktorHofer commented Feb 23, 2024

  1. By using NetMinimum and NetFrameworkMinimum as the TFM properties, the command-line-api build will automatically target the minimum in-support version of .NET and .NET Framework.

  2. Upgrade the TFM to net8.0 as net7.0 is already out-of-support and Tactics (leadership) asked repositories to move away from net7.0 in the main branch (which targets the .NET 9 release in November 2024).

  3. Clean-up a few unnecessary msbuild properties and simplify items.

  4. Clean-up the #if NETX compiler preprocessor directives.

1. By using NetMinimum and NetFrameworkMinimum as the TFM properties,
  the command-line-api repository will automatically target the minimum
  in-support version of .NET and .NET Framework.

2. Upgrade the TFM to net8.0 as net7.0 will soon be out-of-support and
   Tactics (leadership) asked repositories to move away from net7.0
   already in the main branch.

3. Clean-up a few unnecessary msbuild properties and simplify items.

4. Clean-up the #if NETX compiler preprocessor directives.
@ViktorHofer
Copy link
Member Author

ViktorHofer commented Feb 23, 2024

So the ApprovalTests dependency update caused the baseline to be incorrect. I think this is due to a change in their implementation. Meaning, we will need to re-generate the baseline files as part of this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants