-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use NetMinimum and NetFrameworkMinimum floating TFMs #2335
Open
ViktorHofer
wants to merge
10
commits into
main
Choose a base branch
from
UpdateTFMs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. By using NetMinimum and NetFrameworkMinimum as the TFM properties, the command-line-api repository will automatically target the minimum in-support version of .NET and .NET Framework. 2. Upgrade the TFM to net8.0 as net7.0 will soon be out-of-support and Tactics (leadership) asked repositories to move away from net7.0 already in the main branch. 3. Clean-up a few unnecessary msbuild properties and simplify items. 4. Clean-up the #if NETX compiler preprocessor directives.
So the |
...mandLine.NamingConventionBinder.Tests/System.CommandLine.NamingConventionBinder.Tests.csproj
Show resolved
Hide resolved
akoeplinger
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By using NetMinimum and NetFrameworkMinimum as the TFM properties, the command-line-api build will automatically target the minimum in-support version of .NET and .NET Framework.
Upgrade the TFM to net8.0 as net7.0 is already out-of-support and Tactics (leadership) asked repositories to move away from net7.0 in the main branch (which targets the .NET 9 release in November 2024).
Clean-up a few unnecessary msbuild properties and simplify items.
Clean-up the #if NETX compiler preprocessor directives.