Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nested Editor<T> Null Reference Exception. Fix a bug in the HtmlFieldPrefix.cs:23 #58888

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sgarnovsky
Copy link

@sgarnovsky sgarnovsky commented Nov 12, 2024

Actually, a null reference exception occurs when a nested Editor.NameFor() or child component based on InputBase is used. The referenced bug issue has a sample to reproduce this problem.

The fix is a quite simple and probably doesn't require any test unit as an original issue looks like an indexing reference misprint.

It will fix #53956

This a fix for nested Editor<T> described in this issue: dotnet#53956
@sgarnovsky sgarnovsky requested a review from a team as a code owner November 12, 2024 06:41
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-blazor Includes: Blazor, Razor Components label Nov 12, 2024
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Nov 12, 2024
Copy link
Contributor

Thanks for your PR, @sgarnovsky. Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

Copy link
Contributor

Looks like this PR hasn't been active for some time and the codebase could have been changed in the meantime.
To make sure no conflicting changes have occurred, please rerun validation before merging. You can do this by leaving an /azp run comment here (requires commit rights), or by simply closing and reopening.

@dotnet-policy-service dotnet-policy-service bot added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Nov 21, 2024
@pavelsavara
Copy link
Member

this may need backports to 8 and 9

cc @javiercn

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-blazor Includes: Blazor, Razor Components community-contribution Indicates that the PR has been added by a community member pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nested Editor<T> crashing because of bug in HtmlFieldPrefix.Combine method
3 participants