Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/9.0] Fix resource masking #6763

Open
wants to merge 1 commit into
base: release/9.0
Choose a base branch
from
Open

[release/9.0] Fix resource masking #6763

wants to merge 1 commit into from

Conversation

JamesNK
Copy link
Member

@JamesNK JamesNK commented Nov 22, 2024 •
edited
Loading

Fixes #6557

Customer Impact

Repo:

  1. View project details
  2. Click show value for an env var
  3. Restart project
  4. Refreshed project details show values for all env vars

This bug causes sensitive data to unexpectedly be shown in the right circumstances.

Testing

Unit testing.

Manual testing:

release-9-masking

Risk

Low

Regression?

No

Microsoft Reviewers: Open in CodeFlow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamint adamint adamint approved these changes

@radical radical Awaiting requested review from radical radical is a code owner

@eerhardt eerhardt Awaiting requested review from eerhardt eerhardt is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
area-dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JamesNK @adamint