fix type for in memory cache factory (#3000)

* fix type for in memory cache factory

* changeset

* make TypeScript happy with a cast instead of nested function

.changeset/hungry-numbers-burn.md

@@ -0,0 +1,5 @@
+---
+'@graphql-yoga/plugin-response-cache': patch
+---
+
+Fix incompatible type of in-memory cache factory with `cache` option

packages/plugins/response-cache/__tests__/response-cache.spec.ts

@@ -1,6 +1,6 @@
 import { createSchema, createYoga } from 'graphql-yoga';
 import { cacheControlDirective } from '@envelop/response-cache';
-import { useResponseCache } from '@graphql-yoga/plugin-response-cache';
+import { createInMemoryCache, useResponseCache } from '@graphql-yoga/plugin-response-cache';
 
 const schema = createSchema({
   typeDefs: /* GraphQL */ `
@@ -391,3 +391,61 @@ it('should work with @cacheControl directive', async () => {
     },
   });
 });
+
+it('should allow to create the cache outside of the plugin', async () => {
+  const onEnveloped = jest.fn();
+  const yoga = createYoga({
+    schema,
+    plugins: [
+      useResponseCache({
+        session: () => null,
+        includeExtensionMetadata: true,
+        cache: createInMemoryCache(),
+      }),
+      {
+        onEnveloped,
+      },
+    ],
+  });
+  const response = await yoga.fetch('http://localhost:3000/graphql', {
+    method: 'POST',
+    headers: {
+      'content-type': 'application/json',
+    },
+    body: JSON.stringify({ query: '{ _ }' }),
+  });
+
+  expect(response.status).toEqual(200);
+  const body = await response.json();
+  expect(body).toEqual({
+    data: {
+      _: 'DUMMY',
+    },
+    extensions: {
+      responseCache: {
+        didCache: true,
+        hit: false,
+        ttl: null,
+      },
+    },
+  });
+  const response2 = await yoga.fetch('http://localhost:3000/graphql', {
+    method: 'POST',
+    headers: {
+      'content-type': 'application/json',
+    },
+    body: JSON.stringify({ query: '{ _ }' }),
+  });
+  const body2 = await response2.json();
+  expect(body2).toMatchObject({
+    data: {
+      _: 'DUMMY',
+    },
+    extensions: {
+      responseCache: {
+        hit: true,
+      },
+    },
+  });
+  expect(onEnveloped).toHaveBeenCalledTimes(1);
+});

packages/plugins/response-cache/src/index.ts

@@ -2,9 +2,9 @@ import { ExecutionResult } from 'graphql';
 import { Maybe, Plugin, PromiseOrValue, YogaInitialContext, YogaLogger } from 'graphql-yoga';
 import {
   BuildResponseCacheKeyFunction,
-  createInMemoryCache,
   defaultBuildResponseCacheKey,
   Cache as EnvelopCache,
+  createInMemoryCache as envelopCreateInMemoryCache,
   ResponseCacheExtensions as EnvelopResponseCacheExtensions,
   GetDocumentStringFunction,
   useResponseCache as useEnvelopResponseCache,
@@ -160,4 +160,6 @@ export function useResponseCache(options: UseResponseCacheParameter): Plugin {
   };
 }
 
-export { createInMemoryCache };
+export const createInMemoryCache = envelopCreateInMemoryCache as (
+  ...args: Parameters<typeof envelopCreateInMemoryCache>
+) => Cache;