Skip to content

Commit

Permalink
Add Node 21 to CI (#3087)
Browse files Browse the repository at this point in the history
* Node 21

* Revert pnpm lock

* Remove uws from Node 21 tests
  • Loading branch information
ardatan authored Oct 25, 2023
1 parent f2c7bed commit 38f95ef
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
strategy:
fail-fast: false
matrix:
node-version: [18, 20]
node-version: [18, 20, 21]
graphql-version: ['15.8.0', '16.6.0']
steps:
- name: Checkout Repository
Expand Down Expand Up @@ -66,7 +66,7 @@ jobs:
strategy:
fail-fast: false
matrix:
node-version: [18, 20]
node-version: [18, 20, 21]
graphql-version: ['15.8.0', '16.6.0']
steps:
- name: Checkout Repository
Expand Down Expand Up @@ -116,7 +116,7 @@ jobs:
strategy:
fail-fast: false
matrix:
node-version: [18]
node-version: [18, 21]
graphql-version: ['15.8.0', '16.6.0']
steps:
- name: Checkout Repository
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import { fetch } from '@whatwg-node/fetch';

describe('uWebSockets', () => {
const nodeMajor = parseInt(process.versions.node.split('.')[0], 10);
if (nodeMajor < 16) {
if (nodeMajor < 16 || nodeMajor > 20) {
it('should be skipped', () => {});
return;
}
Expand Down

0 comments on commit 38f95ef

Please sign in to comment.