Revert "fix: show ? in !np when slot is still inacurate"

This reverts commit 24185ed.
dotabod · Aug 31, 2024 · 250c1fc · 250c1fc
1 parent 24185ed
commit 250c1fc
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/packages/dota/src/dota/lib/heroes.ts b/packages/dota/src/dota/lib/heroes.ts
@@ -659,7 +659,7 @@ export const translatedColor = (color: string, lng: string) => {
 }
 
 export const heroColors = 'Blue,Teal,Purple,Yellow,Orange,Pink,Olive,Cyan,Green,Brown'.split(',')
-export function getHeroNameOrColor(id?: number, index?: number) {
+export function getHeroNameOrColor(id: number, index?: number) {
   if (!id && typeof index === 'number') return heroColors[index]
 
   const hero = getHeroById(id)

diff --git a/packages/dota/src/steam/notableplayers.ts b/packages/dota/src/steam/notableplayers.ts
@@ -79,14 +79,13 @@ export async function notablePlayers({
     })
 
     const proPlayers: NotablePlayer[] = []
-    matchPlayers.forEach((player, i: number) => {
+    matchPlayers.forEach((player: Player, i: number) => {
       const np = nps.find((np) => np.account_id === player.accountid)
       const props = {
         account_id: player.accountid,
-        heroId: player.heroid ?? 0,
+        heroId: player.heroid,
         position: i,
-        heroName:
-          player.playerid >= 0 ? getHeroNameOrColor(player.heroid ?? 0, player.playerid) : '?',
+        heroName: getHeroNameOrColor(player.heroid, i),
         name: np?.name ?? `Player ${i + 1}`,
         country_code: np?.country_code ?? '',
         isMe: steam32Id === player.accountid,