Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refuse connections to peers running incompatible protocol #2241

Merged
merged 1 commit into from
Oct 15, 2024
Merged

Refuse connections to peers running incompatible protocol #2241

merged 1 commit into from
Oct 15, 2024

Conversation

wizeguyy
Copy link
Member

No description provided.

jdowning100
jdowning100 approved these changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@jdowning100 jdowning100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. This PR made me realize we need to refactor QuaiBackend in p2p_backend.go because we should not be using pointers to interfaces.

@wizeguyy wizeguyy merged commit 0a97c51 into dominant-strategies:main Oct 15, 2024
2 checks passed
@wizeguyy wizeguyy deleted the protoversion-hardass branch October 15, 2024 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gameofpointers gameofpointers gameofpointers approved these changes

@kiltsonfire kiltsonfire kiltsonfire approved these changes

@jdowning100 jdowning100 jdowning100 approved these changes

@Djadih Djadih Djadih approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@wizeguyy @Djadih @jdowning100 @kiltsonfire @gameofpointers