Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(deps-dev): bump eslint-plugin-testing-library from 5.11.0 to 6.1.0 #10

Merged
merged 4 commits into from
Oct 23, 2023
Merged

build(deps-dev): bump eslint-plugin-testing-library from 5.11.0 to 6.1.0 #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
49f5416
build(deps-dev): bump eslint-plugin-testing-library from 5.11.0 to 6.1.0
dependabot[bot] Oct 20, 2023
6c31231
build(deps-dev): bump eslint-plugin-testing-library from 5.11.0 to 6.1.0
dependabot[bot] Oct 23, 2023
d6d17c0
Merge branch 'dependabot/npm_and_yarn/eslint-plugin-testing-library-6…
tbantle22 Oct 23, 2023
b7bb3be
Fix testing lint
tbantle22 Oct 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .eslintrc.react.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,10 @@ module.exports = {
],
rules: {
...rules,
"testing-library/no-node-access": [
"error",
{ allowContainerFirstChild: true },
],
"jsx-a11y/control-has-associated-label": "warn",
"jsx-a11y/anchor-is-valid": "off",
"react-hooks/exhaustive-deps": "warn",
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@
"eslint-plugin-prettier": "^4.2.1",
"eslint-plugin-react": "^7.32.2",
"eslint-plugin-react-hooks": "^4.4.0",
"eslint-plugin-testing-library": "^5.11.0",
"eslint-plugin-testing-library": "^6.1.0",
"npm-run-all": "^4.1.5",
"prettier": "^2.8.3",
"rimraf": "^5.0.5",
Expand Down
2 changes: 1 addition & 1 deletion packages/web/components/FormSelect/index.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ describe("test FormSelect", () => {
if (!menuList) {
throw Error("MenuList not found");
}
expect(menuList.firstElementChild).toHaveTextContent(selected.value);
expect(menuList.firstChild).toHaveTextContent(selected.value);
});
});
});
2 changes: 1 addition & 1 deletion packages/web/components/TextareaWithMarkdown/index.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ describe("test TextareaWithMarkdown", () => {

const lists = screen.getAllByRole("list");
const markdownList = lists[1];
expect(markdownList.childElementCount).toEqual(3);
expect(markdownList.childNodes).toHaveLength(3);

markdownList.childNodes.forEach(mdChild => {
expect(mdChild).toHaveTextContent("Bulletpoint");
Expand Down
1 change: 1 addition & 0 deletions packages/web/components/util/KeyNav/index.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* eslint-disable testing-library/no-node-access */
import { fireEvent, render, screen } from "@testing-library/react";
import KeyNav from ".";

Expand Down
10 changes: 5 additions & 5 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7295,7 +7295,7 @@ __metadata:
eslint-plugin-prettier: ^4.2.1
eslint-plugin-react: ^7.32.2
eslint-plugin-react-hooks: ^4.4.0
eslint-plugin-testing-library: ^5.11.0
eslint-plugin-testing-library: ^6.1.0
npm-run-all: ^4.1.5
prettier: ^2.8.3
rimraf: ^5.0.5
Expand Down Expand Up @@ -7958,14 +7958,14 @@ __metadata:
languageName: node
linkType: hard

"eslint-plugin-testing-library@npm:^5.11.0":
version: 5.11.0
resolution: "eslint-plugin-testing-library@npm:5.11.0"
"eslint-plugin-testing-library@npm:^6.1.0":
version: 6.1.0
resolution: "eslint-plugin-testing-library@npm:6.1.0"
dependencies:
"@typescript-eslint/utils": ^5.58.0
peerDependencies:
eslint: ^7.5.0 || ^8.0.0
checksum: 7f19d3dedd7788b411ca3d9045de682feb26025b9c26d97d4e2f0bf62f5eaa276147d946bd5d0cd967b822e546a954330fdb7ef80485301264f646143f011a02
checksum: 67d2f521a6af623c157d05bbefa743d9aa360d5462a9b38a82a79b0ba008cb4d6ba3f604f54ac9d12405c53b6744695fc7fde7875f2b83aa3f85a8ced7687be3
languageName: node
linkType: hard

Expand Down
Loading