You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an option to allow a property to be inherited by a parent element, False by default because exercises will probably require the elements themselves to have this property.
All validators checks now pass again (#170), only emmet is left.
If you merge this PR after#178, remember to change the base branch to main instead of check_decorators.
allow_inheritance: bool = False Shouldn't we make True the default for this, since this is also how css works?
I wasn't exactly sure what to do with it because, as you said, True also makes sense. I went with the safe route: if the exercise says the <img> should be centered, then require the <img> itself to be centered instead of allowing the entire page to be centered (which coincidentally also centers the <img>). Putting the <img> inside of a centered <div>also centers it, so it's technically correct, but the exercise doesn't really specify if it's allowed or not.
"Make the text red" implies the text itself has to be red, not the entire <body> (which cascades it onto the text).
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
stijndcl
added
documentation
Add an option to allow a property to be inherited by a parent element,
Falseby default because exercises will probably require the elements themselves to have this property.All
validatorschecks now pass again (#170), onlyemmetis left.If you merge this PR after #178, remember to change the base branch to
maininstead ofcheck_decorators.