Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SEAB-6452: add eventtype to s3 #167

Merged
merged 3 commits into from
Jul 11, 2024
Merged

SEAB-6452: add eventtype to s3 #167

merged 3 commits into from
Jul 11, 2024

Conversation

hyunnaye
Copy link
Contributor

@hyunnaye hyunnaye commented Jul 10, 2024

Description
This PR adds the event type to the s3 bucket.
New format of events in bucket

{
  "eventType": <"installation_repositories" or <"push">,
  "body": {...}
}

Issue
https://ucsc-cgl.atlassian.net/browse/SEAB-6452

Security
If there are any concerns that require extra attention from the security team, highlight them here.

Please make sure that you've checked the following before submitting your pull request. Thanks!

  • Ensure that the PR targets the correct branch. Check the milestone or fix version of the ticket.

@hyunnaye hyunnaye self-assigned this Jul 10, 2024
@hyunnaye hyunnaye marked this pull request as ready for review July 10, 2024 21:55
@hyunnaye hyunnaye changed the title add eventtype SEAB-6452: add eventtype Jul 10, 2024
@hyunnaye hyunnaye changed the title SEAB-6452: add eventtype SEAB-6452: add eventtype to s3 Jul 10, 2024
Copy link
Member

@denis-yuen denis-yuen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: would be breaking change, but not an issue since not released to prod yet

Copy link
Contributor

@svonworl svonworl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the work on this, Nayeon! Approved, although my spider sense is tingling just a little bit - someday, who knows, we might need to know some other field from the headers...

@hyunnaye hyunnaye merged commit 19f30c3 into develop Jul 11, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants