propagate both the "added" and "removed" varieties of the "installati…

…on_repositories" event https://ucsc-cgl.atlassian.net/browse/SEAB-6000
dockstore · Mar 27, 2024 · 3afb39f · 3afb39f
1 parent fc32aad
commit 3afb39f
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 23 deletions.
diff --git a/upsertGitHubTag/deployment/index.js b/upsertGitHubTag/deployment/index.js
@@ -166,24 +166,19 @@ function processEvent(event, callback) {
   var githubEventType = requestBody["X-GitHub-Event"];
   // Handle installation events
   if (githubEventType === "installation_repositories") {
-    // Currently ignoring repository removal events, only calling the endpoint if we are adding a repository.
-    if (body.action === "added") {
-      console.log("Valid installation event");
-      path += "workflows/github/install";
-      const repositoriesAdded = body.repositories_added;
-      const repositories = repositoriesAdded.map((repo) => repo.full_name);
-
-      postEndpoint(path, body, deliveryId, (response) => {
-        const successMessage =
-          "The GitHub app was successfully installed on repositories " +
-          repositories;
-        handleCallback(response, successMessage, callback);
-      });
-    } else {
-      console.log(
-        'installation_repositories event ignored "' + body.action + '" action'
-      );
-    }
+    // The installation_repositories event contains information about both additions and removals.
+    console.log("Valid installation event");
+    path += "workflows/github/install";
+    postEndpoint(path, body, deliveryId, (response) => {
+      const added = body.action === "added";
+      const repositories = (
+        added ? body.repositories_added : body.repositories_removed
+      ).map((repo) => repo.full_name);
+      const successMessage = `The GitHub app was successfully ${
+        added ? "installed" : "uninstalled"
+      } on repositories ${repositories}`;
+      handleCallback(response, successMessage, callback);
+    });
   } else if (githubEventType === "push") {
     /**
      * We only handle push events, of which there are many subtypes. Unfortunately, the only way to differentiate between them is to look

diff --git a/wdl-parsing/WDLParsingFunction/pom.xml b/wdl-parsing/WDLParsingFunction/pom.xml
@@ -26,11 +26,6 @@
             <url>https://repo.maven.apache.org/maven2</url>
             <layout>default</layout>
         </repository>
-        <repository>
-            <id>artifacts.oicr.on.ca</id>
-            <name>artifacts.oicr.on.ca</name>
-            <url>https://artifacts.oicr.on.ca/artifactory/collab-release</url>
-        </repository>
         <repository>
             <id>artifactory.broadinstitute.org</id>
             <name>artifactory.broadinstitute.org</name>