Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use reusable deploy artifacts workflow #298

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from

Conversation

kathy-t
Copy link
Contributor

@kathy-t kathy-t commented Nov 25, 2024

Description
See dockstore/workflow-actions#3 for the reusable workflows used in this PR.

This PR combines the tagged_release and deploy_snapshots into one workflow called deploy_artifacts that deploys either a tagged release or branch snapshot to artifactory (see https://github.com/dockstore/dockstore-cli/actions/workflows/deploy_artifacts.yml for examples of the runs). This creates snapshots for feature branches as well. The deploy_artifacts is invoked on push of a tag or branch automatically so we no longer need to manually run the GitHub Action for a release.

The settings.xml files are deleted because the settings are now specified in the reusable deploy_artifacts workflow.

Review Instructions
Builds should pass for the develop branch. Create a new tagged release and verify that the Deploy artifacts GitHub action works.

Issue
https://ucsc-cgl.atlassian.net/browse/SEAB-6771

Security
If there are any concerns that require extra attention from the security team, highlight them here.

Please make sure that you've checked the following before submitting your pull request. Thanks!

  • Check that you pass the basic style checks and unit tests by running ./mvnw clean install
  • If this PR is for a user-facing feature, create and link a documentation ticket for this feature (usually in the same milestone as the linked issue). Style points if you create a documentation PR directly and link that instead.

@kathy-t kathy-t self-assigned this Nov 25, 2024
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.11%. Comparing base (f73108d) to head (3dcbf43).

Additional details and impacted files
@@              Coverage Diff              @@
##             develop     #298      +/-   ##
=============================================
- Coverage      70.12%   70.11%   -0.02%     
+ Complexity      1060     1049      -11     
=============================================
  Files             47       47              
  Lines           6069     6069              
  Branches         801      801              
=============================================
- Hits            4256     4255       -1     
+ Misses          1470     1467       -3     
- Partials         343      347       +4     
Flag Coverage Δ
bitbuckettests 9.83% <ø> (ø)
confidentialtooltests 55.69% <ø> (+0.16%) ⬆️
confidentialworkflowtests 30.26% <ø> (ø)
nonconfidentialtests 32.37% <ø> (-0.02%) ⬇️
singularitytests 16.59% <ø> (ø)
unittests 8.35% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Nov 27, 2024

@kathy-t kathy-t changed the title Use reusable snapshot deploy Use reusable deploy artifacts workflow Nov 27, 2024
@kathy-t kathy-t marked this pull request as ready for review November 27, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants