Refactor/#22 onboarding 화면을 이미지로 변경합니다. #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zero-1016
added
📕Storybook
|
➡️ 추가된 Storybook 미리보기: https://669c8e6cae62e39ff159b378-syqzolleid.chromatic.com/ |
|
➡️ 추가된 Storybook 미리보기: https://669c8e6cae62e39ff159b378-pnypsjvfed.chromatic.com/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR? 🔍
Changes 📝
1. onboarding 화면을 이미지로 변경합니다.
iphone se와 같이 세로 길이가 적을 경우 기존에 꽉찬 height로는 짤리거나 밀리는 현상이 발생하였습니다. 때문에 스크롤이 없는 온보딩의 특성상 작은 화면으로 구성을 하고자 작은 크기의 이미지 영역으로 변경하였습니다.
Screenshot 📷