Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

autograd: user custom function #385

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

iblislin
Copy link
Member

@iblislin iblislin commented Dec 18, 2017

  • an example included: examples/autograd/customfunc.jl

@vchuravy Could you review the GC-related part of this PR?

TODO:

  • support where syntax for @custom

@iblislin iblislin added this to the 0.4.0 milestone Dec 18, 2017
@codecov-io
Copy link

codecov-io commented Dec 18, 2017

Codecov Report

❗ No coverage uploaded for pull request base (master@0fba766). Click here to learn what that means.
The diff coverage is 91.52%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #385   +/-   ##
=========================================
  Coverage          ?   71.28%           
=========================================
  Files             ?       28           
  Lines             ?     2114           
  Branches          ?        0           
=========================================
  Hits              ?     1507           
  Misses            ?      607           
  Partials          ?        0
Impacted Files Coverage Δ
src/MXNet.jl 100% <ø> (ø)
src/base.jl 36.55% <100%> (ø)
src/autograd.jl 95.96% <91.37%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0fba766...d11ab20. Read the comment docs.

@iblislin iblislin changed the title WIP: autograd: user custom function autograd: user custom function Dec 23, 2017
@iblislin
Copy link
Member Author

ready for review

@jekbradbury
Copy link

Any idea what's going wrong with GitHub's triple quote detection such that it thinks the whole autograd.jl is quoted?
In any case this is pretty cool -- something I'd assumed was impossible, and something (fast custom native functions in the frontend's language!) that the Python frontend can never, ever offer.

@iblislin
Copy link
Member Author

Any idea what's going wrong with GitHub's triple quote detection such that it thinks the whole autograd.jl is quoted?

It was an issue of JuliaEditorSupport/atom-language-julia, and fixed in latest release. Just waiting github upgrade their dependency.
See: github-linguist/linguist#3950

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants